From patchwork Fri Jul 15 09:16:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna Kumar X-Patchwork-Id: 104772 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6EBCCB6EE8 for ; Fri, 15 Jul 2011 19:16:32 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965380Ab1GOJQ1 (ORCPT ); Fri, 15 Jul 2011 05:16:27 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:35583 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965364Ab1GOJQ0 (ORCPT ); Fri, 15 Jul 2011 05:16:26 -0400 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp05.in.ibm.com (8.14.4/8.13.1) with ESMTP id p6F9GMPU013086 for ; Fri, 15 Jul 2011 14:46:22 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p6F9GLZU331960 for ; Fri, 15 Jul 2011 14:46:21 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6F9GLt5011381 for ; Fri, 15 Jul 2011 14:46:21 +0530 Received: from krkumar2.in.ibm.com ([9.77.122.132]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p6F9GL48011378; Fri, 15 Jul 2011 14:46:21 +0530 From: Krishna Kumar To: davem@davemloft.net Cc: netdev@vger.kernel.org, Krishna Kumar Date: Fri, 15 Jul 2011 14:46:21 +0530 Message-Id: <20110715091621.23013.37893.sendpatchset@krkumar2.in.ibm.com> Subject: [PATCH] Remove redundant variable/code in __qdisc_run Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove redundant variable "work". Signed-off-by: Krishna Kumar --- net/sched/sch_generic.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -ruNp org/net/sched/sch_generic.c new/net/sched/sch_generic.c --- org/net/sched/sch_generic.c 2011-06-27 16:16:07.000000000 +0530 +++ new/net/sched/sch_generic.c 2011-07-13 10:58:39.000000000 +0530 @@ -190,16 +190,14 @@ static inline int qdisc_restart(struct Q void __qdisc_run(struct Qdisc *q) { int quota = weight_p; - int work = 0; while (qdisc_restart(q)) { - work++; /* * Ordered by possible occurrence: Postpone processing if * 1. we've exceeded packet quota * 2. another process needs the CPU; */ - if (work >= quota || need_resched()) { + if (--quota <= 0 || need_resched()) { __netif_schedule(q); break; }