From patchwork Fri Jul 1 07:25:33 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Klauser X-Patchwork-Id: 102876 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C580AB6F62 for ; Fri, 1 Jul 2011 17:35:24 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755268Ab1GAHfT (ORCPT ); Fri, 1 Jul 2011 03:35:19 -0400 Received: from symlink.to.noone.org ([85.10.207.172]:53064 "EHLO sym.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755254Ab1GAHfS (ORCPT ); Fri, 1 Jul 2011 03:35:18 -0400 X-Greylist: delayed 583 seconds by postgrey-1.27 at vger.kernel.org; Fri, 01 Jul 2011 03:35:18 EDT Received: by sym.noone.org (Postfix, from userid 1002) id E7953895CA2; Fri, 1 Jul 2011 09:25:33 +0200 (CEST) Date: Fri, 1 Jul 2011 09:25:33 +0200 From: Tobias Klauser To: David Miller Cc: grundler@parisc-linux.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: de4x5: Omit check for multicast bit in netdev_for_each_mc_addr Message-ID: <20110701072533.GY28247@distanz.ch> References: <1309349760-1776-1-git-send-email-tklauser@distanz.ch> <20110630.235730.726339338074212677.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110630.235730.726339338074212677.davem@davemloft.net> X-Editor: Vi IMproved 7.1 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2011-07-01 at 08:57:30 +0200, David Miller wrote: > From: Tobias Klauser > Date: Wed, 29 Jun 2011 14:16:00 +0200 > > > There is no need to check for the address being a multicast address in > > the netdev_for_each_mc_addr loop, so remove it. > > > > Signed-off-by: Tobias Klauser > > Please build test your patches! Sorry for the mess. Here's an updated patch, not removing the addrs local variable. There is no need to check for the address being a multicast address in the netdev_for_each_mc_addr loop, so remove it. Signed-off-by: Tobias Klauser --- drivers/net/tulip/de4x5.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c index efaa1d6..d8db2b6 100644 --- a/drivers/net/tulip/de4x5.c +++ b/drivers/net/tulip/de4x5.c @@ -1964,9 +1964,7 @@ SetMulticastFilter(struct net_device *dev) omr |= OMR_PM; /* Pass all multicasts */ } else if (lp->setup_f == HASH_PERF) { /* Hash Filtering */ netdev_for_each_mc_addr(ha, dev) { - addrs = ha->addr; - if ((*addrs & 0x01) == 1) { /* multicast address? */ - crc = ether_crc_le(ETH_ALEN, addrs); + crc = ether_crc_le(ETH_ALEN, ha->addr); hashcode = crc & HASH_BITS; /* hashcode is 9 LSb of CRC */ byte = hashcode >> 3; /* bit[3-8] -> byte in filter */ @@ -1977,7 +1975,6 @@ SetMulticastFilter(struct net_device *dev) byte -= 1; } lp->setup_frame[byte] |= bit; - } } } else { /* Perfect filtering */ netdev_for_each_mc_addr(ha, dev) {