From patchwork Wed Jun 29 06:01:33 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Rothwell X-Patchwork-Id: 102516 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4AABFB6F64 for ; Wed, 29 Jun 2011 16:02:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750Ab1F2GBl (ORCPT ); Wed, 29 Jun 2011 02:01:41 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:42869 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892Ab1F2GBj (ORCPT ); Wed, 29 Jun 2011 02:01:39 -0400 Received: from canb.auug.org.au (ibmaus65.lnk.telstra.net [165.228.126.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtps.tip.net.au (Postfix) with ESMTPSA id 43699144B76; Wed, 29 Jun 2011 16:01:34 +1000 (EST) Date: Wed, 29 Jun 2011 16:01:33 +1000 From: Stephen Rothwell To: David Miller , Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Dobriyan Subject: Re: linux-next: build failure after merge of the final tree (net tree related) Message-Id: <20110629160133.372e53ed.sfr@canb.auug.org.au> In-Reply-To: <20110627153522.8884b125.sfr@canb.auug.org.au> References: <20110623152535.e9ec4ad2.sfr@canb.auug.org.au> <20110627153522.8884b125.sfr@canb.auug.org.au> X-Mailer: Sylpheed 3.1.1 (GTK+ 2.24.4; i486-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi all, On Mon, 27 Jun 2011 15:35:22 +1000 Stephen Rothwell wrote: > > On Thu, 23 Jun 2011 15:25:35 +1000 Stephen Rothwell wrote: > > > > After merging the final tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_read_reg': > > drivers/net/can/sja1000/sja1000_of_platform.c:61:2: error: implicit declaration of function 'in_8' > > drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_write_reg': > > drivers/net/can/sja1000/sja1000_of_platform.c:67:2: error: implicit declaration of function 'out_8' > > drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_remove': > > drivers/net/can/sja1000/sja1000_of_platform.c:81:2: error: implicit declaration of function 'iounmap' > > drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_probe': > > drivers/net/can/sja1000/sja1000_of_platform.c:113:2: error: implicit declaration of function 'ioremap_nocache' > > drivers/net/can/sja1000/sja1000_of_platform.c:113:7: warning: assignment makes pointer from integer without a cast > > > > Since this file has not been changed recently, I suspect that this was > > caused by commit b7f080cfe223 ("net: remove mm.h inclusion from > > netdevice.h"). > > > > I have left the build broken for now since it is also broken for other > > reasons. > > I am still getting these, is there a fix pending? I have to wonder why this has taken so long to be fixed ... I have applied this patch for today: From: Stephen Rothwell Date: Wed, 29 Jun 2011 15:52:00 +1000 Subject: [PATCH] net: include io.h in for iounmap etc fixes these build errors: drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_read_reg': drivers/net/can/sja1000/sja1000_of_platform.c:61:2: error: implicit declaration of function 'in_8' drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_write_reg': drivers/net/can/sja1000/sja1000_of_platform.c:67:2: error: implicit declaration of function 'out_8' drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_remove': drivers/net/can/sja1000/sja1000_of_platform.c:81:2: error: implicit declaration of function 'iounmap' drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_probe': drivers/net/can/sja1000/sja1000_of_platform.c:113:2: error: implicit declaration of function 'ioremap_nocache' drivers/net/can/sja1000/sja1000_of_platform.c:113:7: warning: assignment makes pointer from integer without a cast Caused by commit b7f080cfe223 ("net: remove mm.h inclusion from netdevice.h"). Signed-off-by: Stephen Rothwell --- drivers/net/can/sja1000/sja1000_of_platform.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000_of_platform.c b/drivers/net/can/sja1000/sja1000_of_platform.c index 9793df6..cee6ba2 100644 --- a/drivers/net/can/sja1000/sja1000_of_platform.c +++ b/drivers/net/can/sja1000/sja1000_of_platform.c @@ -38,6 +38,7 @@ #include #include #include +#include #include #include