From patchwork Mon Jun 27 20:42:07 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 102276 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DBF5AB6F68 for ; Tue, 28 Jun 2011 06:49:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754469Ab1F0UsO (ORCPT ); Mon, 27 Jun 2011 16:48:14 -0400 Received: from out3.smtp.messagingengine.com ([66.111.4.27]:40420 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754415Ab1F0Ur7 (ORCPT ); Mon, 27 Jun 2011 16:47:59 -0400 Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44]) by gateway1.messagingengine.com (Postfix) with ESMTP id 9A58720A27; Mon, 27 Jun 2011 16:47:59 -0400 (EDT) Received: from frontend1.messagingengine.com ([10.202.2.160]) by compute4.internal (MEProxy); Mon, 27 Jun 2011 16:47:59 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=date:from:to:subject:message-id:mime-version:content-type; s=smtpout; bh=4I1MvmfnzX2mw+46d7slyF/xZc4=; b=dPLV9NBy2Fq+X+jokfAOamYjwtFF7ltKDBSCn6ifctmmApmox3OmcGrT+cv3xpLT1SiCkcbvd8M59LobwRmrqam6GOvRSXuWLEusqXjnARImNIkQLZqheCeWEJKaW1jGg8yt9aOw9g4ea1LHPGKFbYYFpRZts7wtppyVamXtE+8= X-Sasl-enc: 6Z0d2PU3ACNh1lzv9bnBBlLO331kDnpBxusaESxYoQnm 1309207679 Received: from localhost (c-76-121-69-168.hsd1.wa.comcast.net [76.121.69.168]) by mail.messagingengine.com (Postfix) with ESMTPSA id 26F19409C60; Mon, 27 Jun 2011 16:47:58 -0400 (EDT) Date: Mon, 27 Jun 2011 13:42:07 -0700 From: Greg KH To: Dave Jones , netdev@vger.kernel.org Subject: Fw: Remove over-broad module alias from zaurus. Message-ID: <20110627204207.GB5341@kroah.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This should have gone to netdev@ ----- Forwarded message from Dave Jones ----- Date: Fri, 17 Jun 2011 20:02:10 -0400 From: Dave Jones To: Linux Kernel Cc: linux-usb@vger.kernel.org Subject: Remove over-broad module alias from zaurus. This module and a bunch of dependancies are getting loaded on several of laptops I have (probably picking up the mobile broadband device), that have nothing to do with zaurus. Matching by class without any vendor/device pair isn't the right thing to do here, as it will prevent any other driver from correctly binding to it. (Or in the absense of a driver, will just waste time & memory by unnecessarily loading modules) Signed-off-by: Dave Jones --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ----- End forwarded message ----- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/usb/zaurus.c b/drivers/net/usb/zaurus.c index 241756e..1a2234c 100644 --- a/drivers/net/usb/zaurus.c +++ b/drivers/net/usb/zaurus.c @@ -331,17 +331,7 @@ static const struct usb_device_id products [] = { ZAURUS_MASTER_INTERFACE, .driver_info = ZAURUS_PXA_INFO, }, - - -/* At least some of the newest PXA units have very different lies about - * their standards support: they claim to be cell phones offering - * direct access to their radios! (No, they don't conform to CDC MDLM.) - */ { - USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM, - USB_CDC_PROTO_NONE), - .driver_info = (unsigned long) &bogus_mdlm_info, -}, { /* Motorola MOTOMAGX phones */ USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x6425, USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),