From patchwork Wed Apr 13 19:59:22 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Allan, Bruce W" X-Patchwork-Id: 91093 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A9244B6F17 for ; Thu, 14 Apr 2011 05:59:34 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757657Ab1DMT7a (ORCPT ); Wed, 13 Apr 2011 15:59:30 -0400 Received: from mga11.intel.com ([192.55.52.93]:7608 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752681Ab1DMT73 (ORCPT ); Wed, 13 Apr 2011 15:59:29 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 13 Apr 2011 12:59:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,205,1301900400"; d="scan'208";a="678689169" Received: from gitlad.jf.intel.com ([10.23.23.37]) by fmsmga002.fm.intel.com with ESMTP; 13 Apr 2011 12:59:27 -0700 Received: from gitlad.jf.intel.com (gitlad.jf.intel.com [127.0.0.1]) by gitlad.jf.intel.com (8.14.2/8.14.2) with ESMTP id p3DJxMcv026098; Wed, 13 Apr 2011 12:59:22 -0700 From: Bruce Allan Subject: [net-next-2.6 RFC PATCH v2 07/13] niu: set ethtool set_phys_id on/off cycle frequency to 1/sec To: netdev@vger.kernel.org Cc: Bruce Allan Date: Wed, 13 Apr 2011 12:59:22 -0700 Message-ID: <20110413195922.25901.4053.stgit@gitlad.jf.intel.com> In-Reply-To: <20110413195146.25901.72193.stgit@gitlad.jf.intel.com> References: <20110413195146.25901.72193.stgit@gitlad.jf.intel.com> User-Agent: StGIT/0.14.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Physical identification frequency based on how it was done prior to the introduction of set_phys_id. Compile tested only. Signed-off-by: Bruce Allan --- drivers/net/niu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/niu.c b/drivers/net/niu.c index 3fa1e9c..ea2272f 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -7896,7 +7896,7 @@ static int niu_set_phys_id(struct net_device *dev, switch (state) { case ETHTOOL_ID_ACTIVE: np->orig_led_state = niu_led_state_save(np); - return -EINVAL; + return 1; /* cycle on/off once per second */ case ETHTOOL_ID_ON: niu_force_led(np, 1);