From patchwork Wed Mar 2 20:35:33 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Fastabend X-Patchwork-Id: 85136 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9F10FB70F3 for ; Thu, 3 Mar 2011 07:40:59 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756288Ab1CBUkz (ORCPT ); Wed, 2 Mar 2011 15:40:55 -0500 Received: from mga03.intel.com ([143.182.124.21]:16027 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754696Ab1CBUky (ORCPT ); Wed, 2 Mar 2011 15:40:54 -0500 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 02 Mar 2011 12:40:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.62,255,1297065600"; d="scan'208";a="396549335" Received: from unknown (HELO [127.0.0.1]) ([10.23.209.144]) by azsmga001.ch.intel.com with ESMTP; 02 Mar 2011 12:40:53 -0800 From: John Fastabend Subject: [net-2.6 PATCH] net: dcbnl: check correct ops in dcbnl_ieee_set() To: netdev@vger.kernel.org Cc: john.r.fastabend@intel.com, davem@davemloft.net, shmulikr@broadcom.com Date: Wed, 02 Mar 2011 12:35:33 -0800 Message-ID: <20110302203533.2465.11134.stgit@jf-dev1-dcblab> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The incorrect ops routine was being tested for in DCB_ATTR_IEEE_PFC attributes. This patch corrects it. Currently, every driver implementing ieee_setets also implements ieee_setpfc so this bug is not actualized yet. Signed-off-by: John Fastabend --- net/dcb/dcbnl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c index d5074a5..c44348a 100644 --- a/net/dcb/dcbnl.c +++ b/net/dcb/dcbnl.c @@ -1193,7 +1193,7 @@ static int dcbnl_ieee_set(struct net_device *netdev, struct nlattr **tb, goto err; } - if (ieee[DCB_ATTR_IEEE_PFC] && ops->ieee_setets) { + if (ieee[DCB_ATTR_IEEE_PFC] && ops->ieee_setpfc) { struct ieee_pfc *pfc = nla_data(ieee[DCB_ATTR_IEEE_PFC]); err = ops->ieee_setpfc(netdev, pfc); if (err)