From patchwork Wed Feb 23 23:04:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 84266 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6DA4BB7263 for ; Thu, 24 Feb 2011 10:08:13 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755192Ab1BWXIB (ORCPT ); Wed, 23 Feb 2011 18:08:01 -0500 Received: from suva.vyatta.com ([76.74.103.44]:47474 "EHLO suva.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754774Ab1BWXHt (ORCPT ); Wed, 23 Feb 2011 18:07:49 -0500 Received: from suva.vyatta.com (suva [127.0.0.1]) by suva.vyatta.com (8.13.7/8.13.7) with ESMTP id p1NN7Z2O003723; Wed, 23 Feb 2011 15:07:36 -0800 Received: (from shemminger@localhost) by suva.vyatta.com (8.13.7/8.13.7/Submit) id p1NN7ZxO003722; Wed, 23 Feb 2011 15:07:35 -0800 Message-Id: <20110223230534.268429590@vyatta.com> User-Agent: quilt/0.48-1 Date: Wed, 23 Feb 2011 15:04:19 -0800 From: Stephen Hemminger To: "David S. Miller" Cc: netdev@vger.kernel.org Subject: [PATCH net-next 3/6] netem: define NETEM_DIST_MAX References: <20110223230416.532009518@vyatta.com> Content-Disposition: inline; filename=netem-maxsize.patch Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Rather than magic constant in code, expose the maximum size of packet distribution table in API. In iproute2, q_netem defines MAX_DIST as 16K already. Signed-off-by: Stephen Hemminger --- include/linux/pkt_sched.h | 1 + net/sched/sch_netem.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/include/linux/pkt_sched.h 2011-02-23 14:43:08.838297372 -0800 +++ b/include/linux/pkt_sched.h 2011-02-23 14:50:10.329760558 -0800 @@ -495,6 +495,7 @@ struct tc_netem_corrupt { }; #define NETEM_DIST_SCALE 8192 +#define NETEM_DIST_MAX 16384 /* DRR */ --- a/net/sched/sch_netem.c 2011-02-23 14:50:09.445745344 -0800 +++ b/net/sched/sch_netem.c 2011-02-23 14:50:10.329760558 -0800 @@ -332,7 +332,7 @@ static int get_dist_table(struct Qdisc * int i; size_t s; - if (n > 65536) + if (n > NETEM_DIST_MAX) return -EINVAL; s = sizeof(struct disttable) + n * sizeof(s16);