From patchwork Thu Feb 24 00:52:43 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 84289 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EF4A0B712A for ; Thu, 24 Feb 2011 11:53:43 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635Ab1BXAxi (ORCPT ); Wed, 23 Feb 2011 19:53:38 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55381 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754205Ab1BXAxi (ORCPT ); Wed, 23 Feb 2011 19:53:38 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p1O0qhV4007793 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Feb 2011 16:52:43 -0800 Received: from akpm.mtv.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id p1O0qhfO002444; Wed, 23 Feb 2011 16:52:43 -0800 Date: Wed, 23 Feb 2011 16:52:43 -0800 From: Andrew Morton To: Stephen Hemminger Cc: netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org, bugme-daemon@bugzilla.kernel.org, gbillios@gmail.com Subject: Re: [PATCH] skge: don't mark carrier down at start Message-Id: <20110223165243.8a536913.akpm@linux-foundation.org> In-Reply-To: <20110223164449.2a5206b8@nehalam> References: <20110223162156.17ab2bc5.akpm@linux-foundation.org> <20110223164449.2a5206b8@nehalam> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Spam-Status: No, hits=-104.984 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED, PATCH_SUBJECT_OSDL, USER_IN_WHITELIST X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 23 Feb 2011 16:44:49 -0800 Stephen Hemminger wrote: > The API for network devices has changed so that setting carrier > off at probe is no longer required. This should fix the IPv6 addrconf > issue. > > Signed-off-by: Stephen Hemminger > > > --- a/drivers/net/skge.c 2011-02-23 16:40:36.351045685 -0800 > +++ b/drivers/net/skge.c 2011-02-23 16:40:48.315136410 -0800 > @@ -3856,9 +3856,6 @@ static struct net_device *skge_devinit(s > memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port*8, ETH_ALEN); > memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len); > > - /* device is off until link detection */ > - netif_carrier_off(dev); > - > return dev; > } Thanks, but please don't forget to acknowledge the bug reporter's efforts. Also, quoting the bugzilla URL in the changelog helps when people come along to close off open bug reports. From: Stephen Hemminger The API for network devices has changed so that setting carrier off at probe is no longer required. This should fix the IPv6 addrconf issue. Addresses https://bugzilla.kernel.org/show_bug.cgi?id=29612 Signed-off-by: Stephen Hemminger Reported-by: George Billios Cc: David Miller Signed-off-by: Andrew Morton --- drivers/net/skge.c | 3 --- 1 file changed, 3 deletions(-) diff -puN drivers/net/skge.c~skge-dont-mark-carrier-down-at-start drivers/net/skge.c --- a/drivers/net/skge.c~skge-dont-mark-carrier-down-at-start +++ a/drivers/net/skge.c @@ -3856,9 +3856,6 @@ static struct net_device *skge_devinit(s memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port*8, ETH_ALEN); memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len); - /* device is off until link detection */ - netif_carrier_off(dev); - return dev; }