From patchwork Sun Feb 13 13:37:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Van Dijck X-Patchwork-Id: 82991 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E13ADB7123 for ; Mon, 14 Feb 2011 00:37:28 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754551Ab1BMNhX (ORCPT ); Sun, 13 Feb 2011 08:37:23 -0500 Received: from mailrelay009.isp.belgacom.be ([195.238.6.176]:14373 "EHLO mailrelay009.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754522Ab1BMNhV (ORCPT ); Sun, 13 Feb 2011 08:37:21 -0500 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAONrV01tgner/2dsb2JhbACEHqFidKkfjzuBJ4NBdgSPSw Received: from 171.119-130-109.adsl-dyn.isp.belgacom.be (HELO e-circ.dyndns.org) ([109.130.119.171]) by relay.skynet.be with ESMTP; 13 Feb 2011 14:37:19 +0100 Received: from e-circ.dyndns.org (unknown [192.168.0.71]) by e-circ.dyndns.org (Postfix) with ESMTP id 7BE037B26F; Sun, 13 Feb 2011 14:37:10 +0100 (CET) Date: Sun, 13 Feb 2011 14:37:18 +0100 From: Kurt Van Dijck To: Randy Dunlap Cc: akpm@linux-foundation.org, netdev , linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH -next/mmotm] net/can: fix softing build errors Message-ID: <20110213133717.GA508@e-circ.dyndns.org> References: <201102110100.p1B10sDx029244@imap1.linux-foundation.org> <20110211223312.be571303.randy.dunlap@oracle.com> <20110212111344.GA328@e-circ.dyndns.org> <4D56AF22.4070803@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4D56AF22.4070803@oracle.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 12, 2011 at 08:02:42AM -0800, Randy Dunlap wrote: > On 02/12/11 03:15, Kurt Van Dijck wrote: > > On Fri, Feb 11, 2011 at 10:33:12PM -0800, Randy Dunlap wrote: > >> > >> warning: (CAN_SOFTING_CS) selects CAN_SOFTING which has unmet direct dependencies (NET && CAN && CAN_DEV && HAS_IOMEM) > >> > >> with this partial config: > >> > >> CONFIG_CAN=m > >> # CONFIG_CAN_RAW is not set > >> # CONFIG_CAN_BCM is not set > >> # CAN Device Drivers > >> # CONFIG_CAN_VCAN is not set > >> CONFIG_CAN_SLCAN=m > >> # CONFIG_CAN_DEV is not set > >> CONFIG_CAN_SOFTING=m > >> CONFIG_CAN_SOFTING_CS=m > >> # CONFIG_CAN_DEBUG_DEVICES is not set > > I understand the output, but I don't understand the cause well enough. > > CAN_SOFTING=m has a 'depends on CAN_DEV' > > Is it then possible to have CAN_SOFTING=m _and not_ CAN_DEV ? > > Yes. From Documentation/kbuild/kconfig-language.txt: > I see. The 'select CAN_SOFTING' was introduced because it makes no sense to have CAN_SOFTING_CS alone 'for a normal user', although there is no real dependency. Is a 'select' then still a good option, since it feels like repeating all dependencies from CAN_SOFTING in CAN_SOFTING_CS? What about this? Acked-by: Randy Dunlap --- It will present the Softing stuff in Kconfig as if CAN_SOFTING_CS really depends on CAN_SOFTING, which is acceptible from a users perspective. Kurt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/can/softing/Kconfig b/drivers/net/can/softing/Kconfig index 92bd6bd..55dd3e4 100644 --- a/drivers/net/can/softing/Kconfig +++ b/drivers/net/can/softing/Kconfig @@ -18,7 +18,7 @@ config CAN_SOFTING config CAN_SOFTING_CS tristate "Softing Gmbh CAN pcmcia cards" depends on PCMCIA - select CAN_SOFTING + depends on CAN_SOFTING ---help--- Support for PCMCIA cards from Softing Gmbh & some cards from Vector Gmbh.