| Message ID | 20100713101906.2835.83443.sendpatchset@danny.redhat |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Jul 13, 2010, at 3:19 AM, Xiaotian Feng wrote: > From 6c3a91091b2910c23908a9f9953efcf3df14e522 Mon Sep 17 00:00:00 2001 > From: Xiaotian Feng <dfeng@redhat.com> > Date: Tue, 13 Jul 2010 11:02:41 +0800 > Subject: [PATCH 12/30] selinux: tag avc cache alloc as non-critical > > Failing to allocate a cache entry will only harm performance not correctness. > Do not consume valuable reserve pages for something like that. > > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> > Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de> > Signed-off-by: Xiaotian Feng <dfeng@redhat.com> > --- > security/selinux/avc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > index 3662b0f..9029395 100644 > --- a/security/selinux/avc.c > +++ b/security/selinux/avc.c > @@ -284,7 +284,7 @@ static struct avc_node *avc_alloc_node(void) > { > struct avc_node *node; > > - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC); > + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC); > if (!node) > goto out; > > -- > 1.7.1.1 > Why not just replace GFP_ATOMIC with GFP_NOWAIT? This would NOT consume the valuable last pages. Mitchell Erblich > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/13/2010 06:55 PM, Mitchell Erblich wrote: > > On Jul 13, 2010, at 3:19 AM, Xiaotian Feng wrote: > >> From 6c3a91091b2910c23908a9f9953efcf3df14e522 Mon Sep 17 00:00:00 2001 >> From: Xiaotian Feng<dfeng@redhat.com> >> Date: Tue, 13 Jul 2010 11:02:41 +0800 >> Subject: [PATCH 12/30] selinux: tag avc cache alloc as non-critical >> >> Failing to allocate a cache entry will only harm performance not correctness. >> Do not consume valuable reserve pages for something like that. >> >> Signed-off-by: Peter Zijlstra<a.p.zijlstra@chello.nl> >> Signed-off-by: Suresh Jayaraman<sjayaraman@suse.de> >> Signed-off-by: Xiaotian Feng<dfeng@redhat.com> >> --- >> security/selinux/avc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/security/selinux/avc.c b/security/selinux/avc.c >> index 3662b0f..9029395 100644 >> --- a/security/selinux/avc.c >> +++ b/security/selinux/avc.c >> @@ -284,7 +284,7 @@ static struct avc_node *avc_alloc_node(void) >> { >> struct avc_node *node; >> >> - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC); >> + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC); >> if (!node) >> goto out; >> >> -- >> 1.7.1.1 >> > > Why not just replace GFP_ATOMIC with GFP_NOWAIT? > > This would NOT consume the valuable last pages. But replace GFP_ATOMIC with GFP_NOWAIT can not prevent avc_alloc_node consume reserved pages. > > Mitchell Erblich >> -- >> To unsubscribe from this list: send the line "unsubscribe netdev" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/security/selinux/avc.c b/security/selinux/avc.c index 3662b0f..9029395 100644 --- a/security/selinux/avc.c +++ b/security/selinux/avc.c @@ -284,7 +284,7 @@ static struct avc_node *avc_alloc_node(void) { struct avc_node *node; - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC); + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC); if (!node) goto out;