From patchwork Tue Jun 29 22:53:39 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Casey Leedom X-Patchwork-Id: 57339 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 22CFFB6F06 for ; Wed, 30 Jun 2010 08:57:51 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520Ab0F2W5o (ORCPT ); Tue, 29 Jun 2010 18:57:44 -0400 Received: from stargate.chelsio.com ([67.207.112.58]:10195 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625Ab0F2W5m convert rfc822-to-8bit (ORCPT ); Tue, 29 Jun 2010 18:57:42 -0400 Received: from maui.asicdesigners.com (maui.asicdesigners.com [10.192.180.15]) by stargate.chelsio.com (8.13.1/8.13.1) with SMTP id o5TMvg2o018102 for ; Tue, 29 Jun 2010 15:57:42 -0700 Received: from okham.asicdesigners.com ([10.192.164.4]) by maui.asicdesigners.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 29 Jun 2010 15:53:39 -0700 From: Casey Leedom Organization: Chelsio Communications, Inc. To: netdev@vger.kernel.org Subject: PATCH 1/2] Remove obsolete comment about the lack of a TX Timer Callback -- which we ... Date: Tue, 29 Jun 2010 15:53:39 -0700 User-Agent: KMail/1.13.2 (Linux/2.6.32-22-generic; KDE/4.4.2; x86_64; ; ) MIME-Version: 1.0 Message-Id: <201006291553.39333.leedom@chelsio.com> X-OriginalArrivalTime: 29 Jun 2010 22:53:39.0699 (UTC) FILETIME=[EA574430:01CB17DD] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From fab966adc65f1b500e261867b3cb26bf35482b36 Mon Sep 17 00:00:00 2001 From: Casey Leedom Date: Tue, 29 Jun 2010 15:14:38 -0700 Subject: [PATCH 1/2] Remove obsolete comment about the lack of a TX Timer Callback -- which we now _do_ have ... Signed-off-by: Casey Leedom --- drivers/net/cxgb4vf/sge.c | 13 +------------ 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/net/cxgb4vf/sge.c b/drivers/net/cxgb4vf/sge.c index f857d20..5c4a81d 100644 --- a/drivers/net/cxgb4vf/sge.c +++ b/drivers/net/cxgb4vf/sge.c @@ -1301,18 +1301,7 @@ int t4vf_eth_xmit(struct sk_buff *skb, struct net_device *dev) * wait for acks to really free up the data the extra memory * is even less. On the positive side we run the destructors * on the sending CPU rather than on a potentially different - * completing CPU, usually a good thing. We also run them - * without holding our TX queue lock, unlike what - * reclaim_completed_tx() would otherwise do. - * - * XXX Actually the above is somewhat incorrect since we don't - * XXX yet have a periodic timer which reclaims TX Descriptors. - * XXX What's our plan for this? - * XXX - * XXX Also, we don't currently have a TX Queue lock but - * XXX that may be the result of not having any current - * XXX asynchronous path for reclaiming completed TX - * XXX Descriptors ... + * completing CPU, usually a good thing. * * Run the destructor before telling the DMA engine about the * packet to make sure it doesn't complete and get freed