From patchwork Mon May 3 15:17:45 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 51503 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 79998B7D1E for ; Tue, 4 May 2010 01:17:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932728Ab0ECPRr (ORCPT ); Mon, 3 May 2010 11:17:47 -0400 Received: from Chamillionaire.breakpoint.cc ([85.10.199.196]:57322 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932715Ab0ECPRr (ORCPT ); Mon, 3 May 2010 11:17:47 -0400 Received: id: bigeasy by Chamillionaire.breakpoint.cc with local (easymta 1.00 BETA 1) id 1O8xOz-0004gj-RV; Mon, 03 May 2010 17:17:45 +0200 Date: Mon, 3 May 2010 17:17:45 +0200 From: Sebastian Andrzej Siewior To: Andy Fleming Cc: netdev@vger.kernel.org Subject: [PATCH] net/gianfar: drop recycled skbs on MTU change Message-ID: <20100503151745.GA17997@Chamillionaire.breakpoint.cc> MIME-Version: 1.0 Content-Disposition: inline X-Key-Id: FE3F4706 X-Key-Fingerprint: FFDA BBBB 3563 1B27 75C9 925B 98D5 5C1C FE3F 4706 User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sebastian Andrzej Siewior The size for skb which is added to the recycled list is using the current descriptor size which is current MTU. gfar_new_skb() is also using this size. So after changing or alteast increasing the MTU all recycled skbs should be dropped. Signed-off-by: Sebastian Andrzej Siewior --- I'm not 100% sure but it looks like it is wrong. drivers/net/gianfar.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 5267c27..9093106 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -2287,8 +2287,10 @@ static int gfar_change_mtu(struct net_device *dev, int new_mtu) /* Only stop and start the controller if it isn't already * stopped, and we changed something */ - if ((oldsize != tempsize) && (dev->flags & IFF_UP)) + if ((oldsize != tempsize) && (dev->flags & IFF_UP)) { stop_gfar(dev); + skb_queue_purge(&priv->rx_recycle); + } priv->rx_buffer_size = tempsize;