Message ID | 20100419172731.GA4358@elte.hu |
---|---|
State | Superseded, archived |
Delegated to: | David Miller |
Headers | show |
From: Ingo Molnar <mingo@elte.hu> Date: Mon, 19 Apr 2010 19:27:31 +0200 > Introduced by commit b91ecb00 that got pushed out today. That change removed > an implicit sched.h inclusion that came in via slab.h. > > The patch below fixes it by adding the sched.h dependency. Thanks Ingo, Linus please apply: Acked-by: David S. Miller <davem@davemloft.net> > Ingo > > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c > index f6f45f2..a3aa17f 100644 > --- a/drivers/isdn/gigaset/common.c > +++ b/drivers/isdn/gigaset/common.c > @@ -16,6 +16,7 @@ > #include "gigaset.h" > #include <linux/module.h> > #include <linux/moduleparam.h> > +#include <linux/sched.h> > > /* Version Information */ > #define DRIVER_AUTHOR "Hansjoerg Lipp <hjlipp@web.de>, Tilman Schmidt <tilman@imap.cc>, Stefan Eilers" -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* David Miller <davem@davemloft.net> wrote: > From: Ingo Molnar <mingo@elte.hu> > Date: Mon, 19 Apr 2010 19:27:31 +0200 > > > Introduced by commit b91ecb00 that got pushed out today. That change removed > > an implicit sched.h inclusion that came in via slab.h. > > > > The patch below fixes it by adding the sched.h dependency. > > Thanks Ingo, Linus please apply: > > Acked-by: David S. Miller <davem@davemloft.net> Note, i just found that my patch is not enough as we fail the build elsewhere as well: drivers/isdn/gigaset/proc.c:52: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/proc.c:52: error: (Each undeclared identifier is reported only once drivers/isdn/gigaset/proc.c:52: error: for each function it appears in.) drivers/isdn/gigaset/proc.c:52: error: implicit declaration of function 'schedule' drivers/isdn/gigaset/interface.c:49: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/interface.c:49: error: (Each undeclared identifier is reported only once drivers/isdn/gigaset/interface.c:49: error: for each function it appears in.) drivers/isdn/gigaset/interface.c:49: error: implicit declaration of function 'schedule' drivers/isdn/gigaset/interface.c:83: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/ev-layer.c:981: error: 'TASK_NORMAL' undeclared (first use in this function) drivers/isdn/gigaset/ev-layer.c:981: error: (Each undeclared identifier is reported only once drivers/isdn/gigaset/ev-layer.c:981: error: for each function it appears in.) drivers/isdn/gigaset/ev-layer.c:1001: error: 'TASK_NORMAL' undeclared (first use in this function) drivers/isdn/gigaset/ev-layer.c:1495: error: 'TASK_NORMAL' undeclared (first use in this function) i'd suggest a revert of b91ecb00 instead. Ingo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index f6f45f2..a3aa17f 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c @@ -16,6 +16,7 @@ #include "gigaset.h" #include <linux/module.h> #include <linux/moduleparam.h> +#include <linux/sched.h> /* Version Information */ #define DRIVER_AUTHOR "Hansjoerg Lipp <hjlipp@web.de>, Tilman Schmidt <tilman@imap.cc>, Stefan Eilers"