From patchwork Mon Apr 12 17:38:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 49985 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3E15CB7C33 for ; Tue, 13 Apr 2010 03:38:33 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752141Ab0DLRi2 (ORCPT ); Mon, 12 Apr 2010 13:38:28 -0400 Received: from mail.vyatta.com ([76.74.103.46]:56707 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432Ab0DLRi1 (ORCPT ); Mon, 12 Apr 2010 13:38:27 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.vyatta.com (Postfix) with ESMTP id 2B1C54F4054; Mon, 12 Apr 2010 10:38:22 -0700 (PDT) X-Virus-Scanned: amavisd-new at tahiti.vyatta.com Received: from mail.vyatta.com ([127.0.0.1]) by localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uvi6H1IDqxGU; Mon, 12 Apr 2010 10:38:12 -0700 (PDT) Received: from nehalam (unknown [10.250.0.102]) by mail.vyatta.com (Postfix) with ESMTP id 8BE234F420E; Mon, 12 Apr 2010 10:38:12 -0700 (PDT) Date: Mon, 12 Apr 2010 10:38:05 -0700 From: Stephen Hemminger To: David Miller Cc: netdev@vger.kernel.org Subject: [PATCH] dst: don't inline dst_ifdown Message-ID: <20100412103805.13ac6339@nehalam> Organization: Vyatta X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.3; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The function dst_ifdown is called only two places but in a non- performance critical code path, there is no reason to inline it. Signed-off-by: Stephen Hemminger --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/core/dst.c 2010-04-11 12:30:44.228996074 -0700 +++ b/net/core/dst.c 2010-04-11 12:32:15.488707752 -0700 @@ -285,8 +285,8 @@ EXPORT_SYMBOL(dst_release); * * Commented and originally written by Alexey. */ -static inline void dst_ifdown(struct dst_entry *dst, struct net_device *dev, - int unregister) +static void dst_ifdown(struct dst_entry *dst, struct net_device *dev, + int unregister) { if (dst->ops->ifdown) dst->ops->ifdown(dst, dev, unregister);