From patchwork Tue Mar 30 09:42:09 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 48948 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9BE2DB7BFA for ; Tue, 30 Mar 2010 20:42:42 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756155Ab0C3JmW (ORCPT ); Tue, 30 Mar 2010 05:42:22 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:48146 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752794Ab0C3JmU (ORCPT ); Tue, 30 Mar 2010 05:42:20 -0400 Received: by bwz1 with SMTP id 1so4205939bwz.21 for ; Tue, 30 Mar 2010 02:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mail-followup-to:mime-version:content-type :content-disposition:user-agent; bh=NNhYfsa/s5ZJ/Tt9bui3oLBsoi6/nh+nDqrO31FrRss=; b=bTzAzzBjuELv6jMuzSTxRXmIKvqIcPr85AoRzbtCQo8TT+AZXThA5aE0gG+rDImLgQ 5BuF3FMkVLgt2VHw3wrD7h0TFj0AwJ7EXrzMUYNWAbeTIWUwVAkxOalVNstjSrf8v6FE 56HkNglTgHJ4LWXPQqsDSciRhZgBbrHnnGR0E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; b=QGihrg9WvEiVbtjlAaq33mYhQ6ix/WR35RCBSluxS+tPCrzlRY13+0DJT580fJGIny E9Qd47HHwYa0jNPwyG4hXq9Z7rc7goLHIqG0mR+BMTMLNbLtyMQ0QtnjMTMyN3sLveop 8wKJfEPNfA2HJqJ0EtRzQ6ZTaS611+Bgbl0v0= Received: by 10.204.146.148 with SMTP id h20mr7610670bkv.185.1269942138370; Tue, 30 Mar 2010 02:42:18 -0700 (PDT) Received: from bicker ([196.43.68.110]) by mx.google.com with ESMTPS id 24sm46456833bkr.0.2010.03.30.02.42.14 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 30 Mar 2010 02:42:17 -0700 (PDT) Date: Tue, 30 Mar 2010 12:42:09 +0300 From: Dan Carpenter To: Eric Van Hensbergen Cc: "David S. Miller" , Abhishek Kulkarni , Sripathi Kodi , Latchesar Ionkov , Venkateswararao Jujjuri , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] 9p: saving negative to unsigned char Message-ID: <20100330094209.GI5069@bicker> Mail-Followup-To: Dan Carpenter , Eric Van Hensbergen , "David S. Miller" , Abhishek Kulkarni , Sripathi Kodi , Latchesar Ionkov , Venkateswararao Jujjuri , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Saving -EINVAL as unsigned char truncates the high bits and changes it into 234 instead of -22. This breaks the test for "if (ret == -EINVAL)" in parse_opts(). Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/9p/client.c b/net/9p/client.c index e3e5bf4..edf31aa 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -71,9 +71,10 @@ inline int p9_is_proto_dotu(struct p9_client *clnt) EXPORT_SYMBOL(p9_is_proto_dotu); /* Interpret mount option for protocol version */ -static unsigned char get_protocol_version(const substring_t *name) +static int get_protocol_version(const substring_t *name) { - unsigned char version = -EINVAL; + int version = -EINVAL; + if (!strncmp("9p2000", name->from, name->to-name->from)) { version = p9_proto_legacy; P9_DPRINTK(P9_DEBUG_9P, "Protocol version: Legacy\n");