diff mbox

[-next] net: niu uses crc32, so select CRC32

Message ID 20091210093103.eda05dfe.randy.dunlap@oracle.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Randy Dunlap Dec. 10, 2009, 5:31 p.m. UTC 
From: Randy Dunlap <randy.dunlap@oracle.com>

niu drivers uses crc32 functions, so it needs to select CRC32.

niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/net/Kconfig |    1 +
 1 file changed, 1 insertion(+)

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Dec. 10, 2009, 9:51 p.m. UTC | #1 
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Thu, 10 Dec 2009 09:31:03 -0800

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> niu drivers uses crc32 functions, so it needs to select CRC32.
> 
> niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied, thanks Randy.

That dependency is quite indirect, it's due to ether_crc_*().
I bet a quick grep for that will find several other drivers
missing this Kconfig bit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Randy Dunlap Dec. 10, 2009, 9:59 p.m. UTC | #2 
On Thu, 10 Dec 2009 13:51:38 -0800 (PST) David Miller wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Thu, 10 Dec 2009 09:31:03 -0800
> 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > niu drivers uses crc32 functions, so it needs to select CRC32.
> > 
> > niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Applied, thanks Randy.
> 
> That dependency is quite indirect, it's due to ether_crc_*().
> I bet a quick grep for that will find several other drivers
> missing this Kconfig bit.

Yes, I've noticed that also...

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- linux-next-20091210.orig/drivers/net/Kconfig
+++ linux-next-20091210/drivers/net/Kconfig
@@ -2698,6 +2698,7 @@  config NETXEN_NIC
 config NIU
 	tristate "Sun Neptune 10Gbit Ethernet support"
 	depends on PCI
+	select CRC32
 	help
 	  This enables support for cards based upon Sun's
 	  Neptune chipset.