From patchwork Sun Nov 29 00:17:10 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarek Poplawski X-Patchwork-Id: 39714 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id E64A6B6F05 for ; Sun, 29 Nov 2009 11:18:13 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbZK2ARO (ORCPT ); Sat, 28 Nov 2009 19:17:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753122AbZK2ARO (ORCPT ); Sat, 28 Nov 2009 19:17:14 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:41044 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbZK2ARN (ORCPT ); Sat, 28 Nov 2009 19:17:13 -0500 Received: by fg-out-1718.google.com with SMTP id e12so982863fga.1 for ; Sat, 28 Nov 2009 16:17:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=5Scpgujtavz6WVWTkKopMQEH6xTEt0Wa9360x37yE7o=; b=fJKr0nibeFdexBmffqMreojZZSaRUxHu6w0SNLrnZA8shFPVjdVoANyrX+Mf2TBGKU MW3tBYc3v4wYsmGVmjziAMFWHcaZcAnDNUa157WX0B/tULWCtzrTEXNo6HSCUEVd7xHO HucIw5FFvr4sNq+tfWa59cku0WxJTMDB6AL8g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:in-reply-to:user-agent; b=NC7aoirJ4f7Cn1oYgjI4QHvkmfyPFhTckUrGgGV6diufRTEwDgPnTcIKo/DFdv2u7a g9akyiM6m1v+cQxmpu7ckObVvIusYCSX2EjvfSiKCdIVEq9yFITQIunDGAUYGmlOER0T fYKwGwZ7rgRWvEe0CDy+os1FgD6j5/RuLjhII= Received: by 10.86.104.36 with SMTP id b36mr2540429fgc.42.1259453838527; Sat, 28 Nov 2009 16:17:18 -0800 (PST) Received: from ami.dom.local (public71278.xdsl.centertel.pl [79.162.150.110]) by mx.google.com with ESMTPS id l12sm9899943fgb.0.2009.11.28.16.17.16 (version=SSLv3 cipher=RC4-MD5); Sat, 28 Nov 2009 16:17:17 -0800 (PST) Date: Sun, 29 Nov 2009 01:17:10 +0100 From: Jarek Poplawski To: Philippe De Muyter Cc: grundler@parisc-linux.org, kyle@mcmartin.ca, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: tulip : kernel BUG in tulip_up/tulip_resume Message-ID: <20091129001710.GA4055@ami.dom.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20091108223305.GA21072@frolo.macqel> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Philippe De Muyter wrote, On 11/08/2009 11:33 PM: > Hello, > > I have just installed 2.6.31 (from opensuse 11.2) one a tulip-equipped > computer and I get the following error message from the kernel : > > [ 2495.526390] ------------[ cut here ]------------ > [ 2495.526390] kernel BUG at /usr/src/packages/BUILD/kernel-default-2.6.31.5/linux-2.6.31/include/linux/netdevice.h:439! > [ 2495.526390] invalid opcode: 0000 [#1] SMP ... > This comes from a BUG_ON in napi_enable in netdevice.h. > > napi_enable itself is called by tulip_up as such : > > #ifdef CONFIG_TULIP_NAPI > napi_enable(&tp->napi); > #endif > > At first reading, a matching napi_disable is called in tulip_down. > > Does someone know what could be wrong and have a fix or should I look myself ? Don't know, guess only... Jarek P. --- drivers/net/tulip/tulip_core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c index 0df983b..6b1456c 100644 --- a/drivers/net/tulip/tulip_core.c +++ b/drivers/net/tulip/tulip_core.c @@ -1787,11 +1787,11 @@ static int tulip_resume(struct pci_dev *pdev) return retval; } - netif_device_attach(dev); - if (netif_running(dev)) tulip_up(dev); + netif_device_attach(dev); + return 0; }