From patchwork Thu Nov 19 14:59:03 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick McHardy X-Patchwork-Id: 38841 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 551ED1007D5 for ; Fri, 20 Nov 2009 01:59:16 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756783AbZKSO7C (ORCPT ); Thu, 19 Nov 2009 09:59:02 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752484AbZKSO7A (ORCPT ); Thu, 19 Nov 2009 09:59:00 -0500 Received: from stinky.trash.net ([213.144.137.162]:44356 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699AbZKSO66 (ORCPT ); Thu, 19 Nov 2009 09:58:58 -0500 Received: from x2.localnet (localhost [127.0.0.1]) by stinky.trash.net (Postfix) with ESMTP id CE147B2C53; Thu, 19 Nov 2009 15:59:03 +0100 (MET) From: Patrick McHardy To: davem@davemloft.net Cc: netdev@vger.kernel.org, Patrick McHardy , netfilter-devel@vger.kernel.org Message-Id: <20091119145903.18633.79066.sendpatchset@x2.localnet> In-Reply-To: <20091119145902.18633.28666.sendpatchset@x2.localnet> References: <20091119145902.18633.28666.sendpatchset@x2.localnet> Subject: netfilter 01/02: xt_osf: fix xt_osf_remove_callback() return value Date: Thu, 19 Nov 2009 15:59:03 +0100 (MET) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org commit 1c622ae67bfc729891f5cd80795b15b87e6ac471 Author: Roel Kluin Date: Fri Nov 13 09:31:35 2009 +0100 netfilter: xt_osf: fix xt_osf_remove_callback() return value Return a negative error value. Signed-off-by: Roel Kluin Signed-off-by: Patrick McHardy --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt_osf.c index 63e1905..4d1a41b 100644 --- a/net/netfilter/xt_osf.c +++ b/net/netfilter/xt_osf.c @@ -118,7 +118,7 @@ static int xt_osf_remove_callback(struct sock *ctnl, struct sk_buff *skb, { struct xt_osf_user_finger *f; struct xt_osf_finger *sf; - int err = ENOENT; + int err = -ENOENT; if (!osf_attrs[OSF_ATTR_FINGER]) return -EINVAL;