From patchwork Fri Nov 13 07:46:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ursula Braun X-Patchwork-Id: 38348 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 700CB1007D8 for ; Fri, 13 Nov 2009 18:51:09 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754130AbZKMHuz (ORCPT ); Fri, 13 Nov 2009 02:50:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754044AbZKMHuz (ORCPT ); Fri, 13 Nov 2009 02:50:55 -0500 Received: from mtagate6.de.ibm.com ([195.212.17.166]:43513 "EHLO mtagate6.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbZKMHuq (ORCPT ); Fri, 13 Nov 2009 02:50:46 -0500 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id nAD7oppF007525; Fri, 13 Nov 2009 07:50:51 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nAD7op97913640; Fri, 13 Nov 2009 08:50:51 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id nAD7opw4013545; Fri, 13 Nov 2009 08:50:51 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id nAD7opoZ013540; Fri, 13 Nov 2009 08:50:51 +0100 Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 4267) id F0C10122422C; Fri, 13 Nov 2009 08:50:50 +0100 (CET) Message-Id: <20091113075050.863396000@linux.vnet.ibm.com> User-Agent: quilt/0.47-1 Date: Fri, 13 Nov 2009 08:46:30 +0100 From: Ursula Braun To: davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Ursula Braun Subject: [patch 4/4] [PATCH] netiucv: displayed TX bytes value much too high References: <20091113074626.078348000@linux.vnet.ibm.com> Content-Disposition: inline; filename=616-netiucv-tx-bytes.diff Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ursula Braun tx_bytes value must be updated by skb length before skb is freed. Signed-off-by: Ursula Braun --- drivers/s390/net/netiucv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-next-uschi/drivers/s390/net/netiucv.c =================================================================== --- linux-next-uschi.orig/drivers/s390/net/netiucv.c +++ linux-next-uschi/drivers/s390/net/netiucv.c @@ -739,13 +739,13 @@ static void conn_action_txdone(fsm_insta if (single_flag) { if ((skb = skb_dequeue(&conn->commit_queue))) { atomic_dec(&skb->users); - dev_kfree_skb_any(skb); if (privptr) { privptr->stats.tx_packets++; privptr->stats.tx_bytes += (skb->len - NETIUCV_HDRLEN - - NETIUCV_HDRLEN); + - NETIUCV_HDRLEN); } + dev_kfree_skb_any(skb); } } conn->tx_buff->data = conn->tx_buff->head;