From patchwork Wed Sep 30 22:08:37 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirsher, Jeffrey T" X-Patchwork-Id: 34636 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 68D25B7BC7 for ; Thu, 1 Oct 2009 08:09:48 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726AbZI3WJj (ORCPT ); Wed, 30 Sep 2009 18:09:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754238AbZI3WJj (ORCPT ); Wed, 30 Sep 2009 18:09:39 -0400 Received: from qmta12.westchester.pa.mail.comcast.net ([76.96.59.227]:38946 "EHLO QMTA12.westchester.pa.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753827AbZI3WJi (ORCPT ); Wed, 30 Sep 2009 18:09:38 -0400 Received: from OMTA16.westchester.pa.mail.comcast.net ([76.96.62.88]) by QMTA12.westchester.pa.mail.comcast.net with comcast id n94C1c00g1uE5Es5CA9jih; Wed, 30 Sep 2009 22:09:43 +0000 Received: from localhost.localdomain ([63.64.152.142]) by OMTA16.westchester.pa.mail.comcast.net with comcast id nAG91c00534bfcX3cAGC70; Wed, 30 Sep 2009 22:16:24 +0000 From: Jeff Kirsher Subject: [net-2.6 PATCH 5/5] ixgbe: Remove ATR computation for UDP traffic To: davem@davemloft.net Cc: netdev@vger.kernel.org, gospo@redhat.com, Peter P Waskiewicz Jr , Jeff Kirsher Date: Wed, 30 Sep 2009 15:08:37 -0700 Message-ID: <20090930220836.27479.74285.stgit@localhost.localdomain> In-Reply-To: <20090930220705.27479.62694.stgit@localhost.localdomain> References: <20090930220705.27479.62694.stgit@localhost.localdomain> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Peter P Waskiewicz Jr ATR support for UDP on 82599 needs to be redesigned, since the current model doesn't make much sense. The fallout from having it in though is it causes all UDP traffic to still compute the ATR hashes on transmit, which are useless. This removal will return upwards of 10% of relative computational overhead in forwarding tests. Signed-off-by: Peter P Waskiewicz Jr Signed-off-by: Jeff Kirsher --- drivers/net/ixgbe/ixgbe_main.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 9609673..1cbc6a3 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -5091,7 +5091,6 @@ static void ixgbe_atr(struct ixgbe_adapter *adapter, struct sk_buff *skb, /* Right now, we support IPv4 only */ struct ixgbe_atr_input atr_input; struct tcphdr *th; - struct udphdr *uh; struct iphdr *iph = ip_hdr(skb); struct ethhdr *eth = (struct ethhdr *)skb->data; u16 vlan_id, src_port, dst_port, flex_bytes; @@ -5105,12 +5104,6 @@ static void ixgbe_atr(struct ixgbe_adapter *adapter, struct sk_buff *skb, dst_port = th->dest; l4type |= IXGBE_ATR_L4TYPE_TCP; /* l4type IPv4 type is 0, no need to assign */ - } else if(iph->protocol == IPPROTO_UDP) { - uh = udp_hdr(skb); - src_port = uh->source; - dst_port = uh->dest; - l4type |= IXGBE_ATR_L4TYPE_UDP; - /* l4type IPv4 type is 0, no need to assign */ } else { /* Unsupported L4 header, just bail here */ return;