From patchwork Tue Sep 15 18:51:12 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyrill Gorcunov X-Patchwork-Id: 33657 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 17A48B6F20 for ; Wed, 16 Sep 2009 04:52:10 +1000 (EST) Received: by ozlabs.org (Postfix) id 0AA2CDDD0B; Wed, 16 Sep 2009 04:52:10 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id A8FBEDDD01 for ; Wed, 16 Sep 2009 04:52:09 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758302AbZIOSvO (ORCPT ); Tue, 15 Sep 2009 14:51:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754518AbZIOSvN (ORCPT ); Tue, 15 Sep 2009 14:51:13 -0400 Received: from mail-ew0-f206.google.com ([209.85.219.206]:44661 "EHLO mail-ew0-f206.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbZIOSvL (ORCPT ); Tue, 15 Sep 2009 14:51:11 -0400 Received: by ewy2 with SMTP id 2so755624ewy.17 for ; Tue, 15 Sep 2009 11:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=MMmO7zneJlovxkDsa6vJBcEea9EJxRuZXu8R61BSiII=; b=NI4Nd8RT6WQLmzAVDGAsHLoNeRXxike8/HWu2IbVkJsJaIVxFa5mFMJT833TGcZzkv FvY7BXFxqTSlz16QwglzCJlenV8fbKa4vrv74e3oHiMDGkR+kwjpFWa+N4M6tuJcbI0T Z7j6J2ej+sxTS+1GrN/UhVLxVAqQ7OzrZHV4g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=iWP13MNaBSZLY8qh11e1dWa1p0zbvxSb9fwYpQ71wWK1zWzG96HDqRIhXW1AOtq+pe i5R3SrKqQddQys1vckv6EUH+iArQ4CLEnOfgvhBk1eoTw/fyBVUXekmigBIqlbdf3zR5 dlHU8ILBHDrZlDieDSr4aveV7KAvwFGiedER4= Received: by 10.210.96.21 with SMTP id t21mr1339479ebb.4.1253040673363; Tue, 15 Sep 2009 11:51:13 -0700 (PDT) Received: from gorcunov (95-28-133-117.broadband.corbina.ru [95.28.133.117]) by mx.google.com with ESMTPS id 5sm835775eyf.41.2009.09.15.11.51.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 15 Sep 2009 11:51:12 -0700 (PDT) Received: by gorcunov (Postfix, from userid 1000) id 66D0DABE; Tue, 15 Sep 2009 22:51:12 +0400 (MSD) Date: Tue, 15 Sep 2009 22:51:12 +0400 From: Cyrill Gorcunov To: Ingo Molnar Cc: David Miller , torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [crash] kernel BUG at net/core/pktgen.c:3503! Message-ID: <20090915185112.GA17587@lenovo> References: <20090911.202543.52533792.davem@davemloft.net> <20090915183647.GA11628@elte.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090915183647.GA11628@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org [Ingo Molnar - Tue, Sep 15, 2009 at 08:36:47PM +0200] | | not sure which merge caused this, but i got this boot crash with latest | -git: | | calling flow_cache_init+0x0/0x1b9 @ 1 | initcall flow_cache_init+0x0/0x1b9 returned 0 after 64 usecs | calling pg_init+0x0/0x37c @ 1 | pktgen 2.72: Packet Generator for packet performance testing. | ------------[ cut here ]------------ | kernel BUG at net/core/pktgen.c:3503! | invalid opcode: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC | last sysfs file: | Hi Ingo, just curious, will the following patch fix the problem? I've been fixing problem with familiar symthoms on system with custome virtual cpu implementation so it may not help in mainline but anyway :) -- Cyrill --- net/core/pktgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6.git/net/core/pktgen.c ===================================================================== --- linux-2.6.git.orig/net/core/pktgen.c +++ linux-2.6.git/net/core/pktgen.c @@ -3511,7 +3511,7 @@ static int pktgen_thread_worker(void *ar struct pktgen_dev *pkt_dev = NULL; int cpu = t->cpu; - BUG_ON(smp_processor_id() != cpu); + BUG_ON(task_cpu(current) != cpu); init_waitqueue_head(&t->queue); complete(&t->start_done);