From patchwork Fri Sep 4 03:02:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Feldman X-Patchwork-Id: 32968 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 0C7E1B70B3 for ; Fri, 4 Sep 2009 13:02:57 +1000 (EST) Received: by ozlabs.org (Postfix) id F2101DDDA0; Fri, 4 Sep 2009 13:02:56 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 4B6F9DDD1B for ; Fri, 4 Sep 2009 13:02:56 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932799AbZIDDCi (ORCPT ); Thu, 3 Sep 2009 23:02:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932795AbZIDDCi (ORCPT ); Thu, 3 Sep 2009 23:02:38 -0400 Received: from sj-iport-6.cisco.com ([171.71.176.117]:19010 "EHLO sj-iport-6.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932789AbZIDDCh (ORCPT ); Thu, 3 Sep 2009 23:02:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhgFAAcgoEqrR7PD/2dsb2JhbACBU8BJiEEBkCsFhBs X-IronPort-AV: E=Sophos;i="4.44,329,1249257600"; d="scan'208";a="381714670" Received: from sj-dkim-3.cisco.com ([171.71.179.195]) by sj-iport-6.cisco.com with ESMTP; 04 Sep 2009 03:02:40 +0000 Received: from sj-core-5.cisco.com (sj-core-5.cisco.com [171.71.177.238]) by sj-dkim-3.cisco.com (8.12.11/8.12.11) with ESMTP id n8432e4E016640; Thu, 3 Sep 2009 20:02:40 -0700 Received: from palito_client100.nuovasystems.com (savbu-palito-client100.cisco.com [10.193.70.13]) by sj-core-5.cisco.com (8.13.8/8.14.3) with ESMTP id n8432eZI002937; Fri, 4 Sep 2009 03:02:40 GMT From: Scott Feldman Subject: [net-next PATCH 10/11] enic: bug fix: check for zero port MTU before posting warning To: davem@davemloft.net Cc: netdev@vger.kernel.org Date: Thu, 03 Sep 2009 20:02:40 -0700 Message-ID: <20090904030240.5047.72108.stgit@palito_client100.nuovasystems.com> In-Reply-To: <20090904030046.5047.46509.stgit@palito_client100.nuovasystems.com> References: <20090904030046.5047.46509.stgit@palito_client100.nuovasystems.com> User-Agent: StGIT/0.12.1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; l=796; t=1252033360; x=1252897360; c=relaxed/simple; s=sjdkim3002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=scofeldm@cisco.com; z=From:=20Scott=20Feldman=20 |Subject:=20[net-next=20PATCH=2010/11]=20enic=3A=20bug=20fi x=3A=20check=20for=20zero=20port=20MTU=20before=0A=09posting =20warning |Sender:=20; bh=jBgx6tvcldngC470iqY474OIpeaQc3jMgQZHXKI3AGM=; b=byE8n88Z/RhAsGjpWKPHoYqlSvRqjcUPhgxehn4mkEMLC96dGikDBtkfA+ bTgcN14AhbvbXULESKQAh3Rmcqxb/8rXex5G2tLUJ+T2I64FT2FT91Auh9y4 mem6b8ouV8; Authentication-Results: sj-dkim-3; header.From=scofeldm@cisco.com; dkim=pass ( sig from cisco.com/sjdkim3002 verified; ); Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org enic: bug fix: check for zero port MTU before posting warning Nic firmware can return zero for port MTU, so check for non-zero value before checking for change in port MTU. Signed-off-by: Scott Feldman --- drivers/net/enic/enic_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 3a55669..9368dae 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -362,7 +362,7 @@ static void enic_mtu_check(struct enic *enic) { u32 mtu = vnic_dev_mtu(enic->vdev); - if (mtu != enic->port_mtu) { + if (mtu && mtu != enic->port_mtu) { if (mtu < enic->netdev->mtu) printk(KERN_WARNING PFX "%s: interface MTU (%d) set higher "