From patchwork Tue Jul 21 18:11:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerrit Renker X-Patchwork-Id: 30048 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 6257BB70B0 for ; Wed, 22 Jul 2009 04:12:26 +1000 (EST) Received: by ozlabs.org (Postfix) id 51BF0DDD1C; Wed, 22 Jul 2009 04:12:26 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id E3633DDD1B for ; Wed, 22 Jul 2009 04:12:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbZGUSMF (ORCPT ); Tue, 21 Jul 2009 14:12:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751973AbZGUSMF (ORCPT ); Tue, 21 Jul 2009 14:12:05 -0400 Received: from dee.erg.abdn.ac.uk ([139.133.204.82]:42268 "EHLO erg.abdn.ac.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751674AbZGUSME (ORCPT ); Tue, 21 Jul 2009 14:12:04 -0400 Received: from laptev.erg.abdn.ac.uk (Debian-exim@ra-gerrit.erg.abdn.ac.uk [139.133.204.38]) by erg.abdn.ac.uk (8.13.4/8.13.4) with ESMTP id n6LIBqfZ006430 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 21 Jul 2009 19:11:53 +0100 (BST) Received: from gerrit by laptev.erg.abdn.ac.uk with local (Exim 4.69) (envelope-from ) id 1MTJof-0001a6-Bx; Tue, 21 Jul 2009 20:11:53 +0200 Date: Tue, 21 Jul 2009 20:11:53 +0200 From: Gerrit Renker To: "David S. Miller" , David L Stevens Cc: netdev@vger.kernel.org Subject: [PATCHv2 1/2] mcastv6: Local variable shadows function argument Message-ID: <20090721181153.GA5970@gerrit.erg.abdn.ac.uk> Mail-Followup-To: Gerrit Renker , "David S. Miller" , David L Stevens , netdev@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-ERG-MailScanner: Found to be clean X-ERG-MailScanner-From: gerrit@erg.abdn.ac.uk X-Spam-Status: No Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi David, can you please apply this small one. Thanks to David L Stevens for clarification. Gerrit >>>>>>>>>>>>>>>>>>> Patch <<<<<<<<<<<<<<<<<<<<<<<<<<<<<< mcastv6: Local variable shadows function argument The local variable 'idev' shadows the function argument 'idev' to ip6_mc_add_src(). Fixed by removing the local declaration, as pmc->idev should be identical with 'idev' passed as argument. Signed-off-by: Gerrit Renker Acked-by: David L Stevens --- net/ipv6/mcast.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -2107,7 +2107,6 @@ static int ip6_mc_add_src(struct inet6_d for (j=0; jmca_sfcount[MCAST_EXCLUDE] != 0)) { - struct inet6_dev *idev = pmc->idev; struct ip6_sf_list *psf; /* filter mode change */