From patchwork Tue Jun 23 15:04:29 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 29076 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4FC81B7095 for ; Wed, 24 Jun 2009 01:30:46 +1000 (EST) Received: by ozlabs.org (Postfix) id 44293DDDF4; Wed, 24 Jun 2009 01:30:46 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B8920DDDF0 for ; Wed, 24 Jun 2009 01:30:45 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759619AbZFWPa3 (ORCPT ); Tue, 23 Jun 2009 11:30:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756269AbZFWP34 (ORCPT ); Tue, 23 Jun 2009 11:29:56 -0400 Received: from lanfw001a.cxnet.dk ([87.72.215.196]:49575 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756870AbZFWP3v (ORCPT ); Tue, 23 Jun 2009 11:29:51 -0400 Received: from hotlava.cxnet.dk (unknown [172.31.4.152]) by lanfw001a.cxnet.dk (Postfix) with ESMTP id 7557C16385C; Tue, 23 Jun 2009 17:04:29 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by hotlava.cxnet.dk (Postfix) with ESMTP id 6553C45C068; Tue, 23 Jun 2009 17:04:29 +0200 (CEST) From: Jesper Dangaard Brouer Subject: [PATCH 07/10] decnet: Use rcu_barrier() on module unload. To: "David S. Miller" Cc: Jesper Dangaard Brouer , "Paul E. McKenney" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dougthompson@xmission.com, bluesmoke-devel@lists.sourceforge.net, axboe@kernel.dk, "Patrick McHardy" , christine.caulfield@googlemail.com, Trond.Myklebust@netapp.com, linux-wireless@vger.kernel.org, johannes@sipsolutions.net, yoshfuji@linux-ipv6.org, shemminger@linux-foundation.org, linux-nfs@vger.kernel.org, bfields@fieldses.org, neilb@suse.de, linux-ext4@vger.kernel.org, tytso@mit.edu, adilger@sun.com, netfilter-devel@vger.kernel.org Date: Tue, 23 Jun 2009 17:04:29 +0200 Message-ID: <20090623150429.22490.15113.stgit@localhost> In-Reply-To: <20090623150330.22490.87327.stgit@localhost> References: <20090623150330.22490.87327.stgit@localhost> User-Agent: StGIT/0.14.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The decnet module unloading as been disabled with a '#if 0' statement, because it have had issues. Perhaps using rcu_barrier() will fix these issues? Any maintainers with input? Signed-off-by: Jesper Dangaard Brouer --- net/decnet/af_decnet.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index d351b8d..bff12da 100644 --- a/net/decnet/af_decnet.c +++ b/net/decnet/af_decnet.c @@ -2393,6 +2393,10 @@ module_init(decnet_init); * Prevent DECnet module unloading until its fixed properly. * Requires an audit of the code to check for memory leaks and * initialisation problems etc. + * + * hawk@comx.dk 2009-06-19: + * I have added a rcu_barrier() which should plug some of your + * module unload issues. Maintainers please try it out... */ #if 0 static void __exit decnet_exit(void) @@ -2413,6 +2417,8 @@ static void __exit decnet_exit(void) proc_net_remove(&init_net, "decnet"); proto_unregister(&dn_proto); + + rcu_barrier_bh(); /* Wait for completion of call_rcu_bh()'s */ } module_exit(decnet_exit); #endif