From patchwork Wed May 20 06:16:20 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirsher, Jeffrey T" X-Patchwork-Id: 27443 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id E260CB7067 for ; Wed, 20 May 2009 16:16:45 +1000 (EST) Received: by ozlabs.org (Postfix) id D3E46DE14E; Wed, 20 May 2009 16:16:45 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 5901EDE14D for ; Wed, 20 May 2009 16:16:45 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbZETGQi (ORCPT ); Wed, 20 May 2009 02:16:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751869AbZETGQh (ORCPT ); Wed, 20 May 2009 02:16:37 -0400 Received: from qmta08.emeryville.ca.mail.comcast.net ([76.96.30.80]:58647 "EHLO QMTA08.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbZETGQg (ORCPT ); Wed, 20 May 2009 02:16:36 -0400 Received: from OMTA14.emeryville.ca.mail.comcast.net ([76.96.30.60]) by QMTA08.emeryville.ca.mail.comcast.net with comcast id thjF1b0081HpZEsA8iGfow; Wed, 20 May 2009 06:16:39 +0000 Received: from localhost.localdomain ([63.64.152.142]) by OMTA14.emeryville.ca.mail.comcast.net with comcast id tiGN1b00934bfcX8aiGQo9; Wed, 20 May 2009 06:16:37 +0000 From: Jeff Kirsher Subject: [PATCH] igb: fix LRO warning To: greg@kroah.com Cc: netdev@vger.kernel.org, stable@kernel.org, Jeff Kirsher , Stephen Hemminger Date: Tue, 19 May 2009 23:16:20 -0700 Message-ID: <20090520061619.13507.27784.stgit@localhost.localdomain> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org igb supports LRO, but was not setting any hooks to the ->set_flags ethtool_ops function. This would trigger warnings if the user tried to enable or disable LRO. Based on the patch provided by Stephen Hemminger Reported-by: Sergey Kononenko Signed-off-by: Jeff Kirsher CC: Stephen Hemminger --- drivers/net/igb/igb_ethtool.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/igb/igb_ethtool.c b/drivers/net/igb/igb_ethtool.c index 3c831f1..44ceb36 100644 --- a/drivers/net/igb/igb_ethtool.c +++ b/drivers/net/igb/igb_ethtool.c @@ -2024,6 +2024,10 @@ static struct ethtool_ops igb_ethtool_ops = { .get_ethtool_stats = igb_get_ethtool_stats, .get_coalesce = igb_get_coalesce, .set_coalesce = igb_set_coalesce, + .get_flags = ethtool_op_get_flags, +#ifdef CONFIG_IGB_LRO + .set_flags = ethtool_op_set_flags, +#endif }; void igb_set_ethtool_ops(struct net_device *netdev)