| Message ID | 20090515091158.55090cd0@nehalam |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Stephen Hemminger <shemminger@vyatta.com> Date: Fri, 15 May 2009 09:11:58 -0700 > If bridge is configured with no STP and forwarding delay of 0 (which > is typical for virtualization) then when link starts it will flood all > packets for the first 20 seconds. > > This bug was introduced by a combination of earlier changes: > * forwarding database uses hold time of zero to indicate > user wants to always flood packets > * optimzation of the case of forwarding delay of 0 avoids the initial > timer tick > > The fix is to just skip all the topology change detection code if > kernel STP is not being used. > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Also applied, thanks Stephen. To avoid confusion, I did apply these to net-2.6 since they are fixes. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/net/bridge/br_stp.c 2009-05-14 13:34:49.965908836 -0700 +++ b/net/bridge/br_stp.c 2009-05-14 14:15:11.370903917 -0700 @@ -297,6 +297,9 @@ void br_topology_change_detection(struct { int isroot = br_is_root_bridge(br); + if (br->stp_enabled != BR_KERNEL_STP) + return; + pr_info("%s: topology change detected, %s\n", br->dev->name, isroot ? "propagating" : "sending tcn bpdu");
If bridge is configured with no STP and forwarding delay of 0 (which is typical for virtualization) then when link starts it will flood all packets for the first 20 seconds. This bug was introduced by a combination of earlier changes: * forwarding database uses hold time of zero to indicate user wants to always flood packets * optimzation of the case of forwarding delay of 0 avoids the initial timer tick The fix is to just skip all the topology change detection code if kernel STP is not being used. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html