From patchwork Wed Apr 1 07:33:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirsher, Jeffrey T" X-Patchwork-Id: 25469 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 1A3C8DDDF3 for ; Wed, 1 Apr 2009 18:34:14 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759573AbZDAHeK (ORCPT ); Wed, 1 Apr 2009 03:34:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759248AbZDAHeJ (ORCPT ); Wed, 1 Apr 2009 03:34:09 -0400 Received: from qmta11.emeryville.ca.mail.comcast.net ([76.96.27.211]:48763 "EHLO QMTA11.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758863AbZDAHeI (ORCPT ); Wed, 1 Apr 2009 03:34:08 -0400 Received: from OMTA06.emeryville.ca.mail.comcast.net ([76.96.30.51]) by QMTA11.emeryville.ca.mail.comcast.net with comcast id a7a51b00116AWCUAB7a5pt; Wed, 01 Apr 2009 07:34:05 +0000 Received: from lost.foo-projects.org ([63.64.152.142]) by OMTA06.emeryville.ca.mail.comcast.net with comcast id a7Zl1b00334bfcX8S7Zn9o; Wed, 01 Apr 2009 07:34:03 +0000 From: Jeff Kirsher Subject: [PATCH 4/9] ixgbe: feature - driver to default with FC on. To: davem@davemloft.net Cc: netdev@vger.kernel.org, gospo@redhat.com, Don Skidmore , Mallikarjuna R Chilakala , Peter P Waskiewicz Jr , Jeff Kirsher Date: Wed, 01 Apr 2009 00:33:44 -0700 Message-ID: <20090401073343.3749.23654.stgit@lost.foo-projects.org> In-Reply-To: <20090401073241.3749.36391.stgit@lost.foo-projects.org> References: <20090401073241.3749.36391.stgit@lost.foo-projects.org> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Don Skidmore In the past flow control wasn't enabled by default under the incorrect assumption that this opened up us to a denial of service attack. However since any switch that forwarded flow control would be extremely msiconfigured and/or buggy, this concern no longer out weighs the preformance gains from having FC enabled. Signed-off-by: Don Skidmore Acked-by: Mallikarjuna R Chilakala Acked-by: Peter P Waskiewicz Jr Signed-off-by: Jeff Kirsher --- drivers/net/ixgbe/ixgbe_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index fd27513..8f6e263 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -3169,7 +3169,7 @@ static int __devinit ixgbe_sw_init(struct ixgbe_adapter *adapter) #endif /* default flow control settings */ - hw->fc.requested_mode = ixgbe_fc_none; + hw->fc.requested_mode = ixgbe_fc_full; hw->fc.high_water = IXGBE_DEFAULT_FCRTH; hw->fc.low_water = IXGBE_DEFAULT_FCRTL; hw->fc.pause_time = IXGBE_DEFAULT_FCPAUSE;