From patchwork Mon Mar 9 18:16:29 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyrill Gorcunov X-Patchwork-Id: 24212 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 7A057DE10E for ; Tue, 10 Mar 2009 05:27:35 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753829AbZCIS10 (ORCPT ); Mon, 9 Mar 2009 14:27:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753365AbZCIS1Z (ORCPT ); Mon, 9 Mar 2009 14:27:25 -0400 Received: from ti-out-0910.google.com ([209.85.142.189]:9772 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbZCIS1Y (ORCPT ); Mon, 9 Mar 2009 14:27:24 -0400 Received: by ti-out-0910.google.com with SMTP id d10so1237110tib.23 for ; Mon, 09 Mar 2009 11:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:message-id :user-agent:date:from:to:cc:subject:references:content-disposition; bh=8WZt9UtXKHs2JYvYJw2fIsa+vtwrmHGBiAUjnOjoE4k=; b=hiruV6FAt/cXv5sGY3WuwSyb/fN0IF3gMxrq/wulr3xEhf7ZZ1GLq72dcAPa/Peua4 gW54fJO2FNHezy6K6ncPDYEPA0M2aIlrH6BmI+c6I9Ev8KtOeZcCDvxlhVKGX8fDp7bX eem6ojAzHHYP1NDuO+DBEsGjQfzbMLEmPaZF8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:user-agent:date:from:to:cc:subject:references :content-disposition; b=RDmy4BvGrVzb2WINdWLjRhD+MlJ5IJyFmAUUygPAHh6KV1ku73EJZGU50Wx7tR472v Ss8bWSsFddYrGdHs/GYhdJrAHlLGj7uM4kmQDSEBwx8Btyf8oXjaaLWcR3hjAhQ+OdZM JxQ1M3eCtZhxwvZ5SLDtnBWSEziHvDoIkYrHE= Received: by 10.110.42.1 with SMTP id p1mr8831615tip.12.1236623239303; Mon, 09 Mar 2009 11:27:19 -0700 (PDT) Received: from gorcunov (95-28-133-54.broadband.corbina.ru [95.28.133.54]) by mx.google.com with ESMTPS id d4sm1833294tib.28.2009.03.09.11.27.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 09 Mar 2009 11:27:18 -0700 (PDT) Received: by gorcunov (Postfix, from userid 1000) id B78F420BF; Mon, 9 Mar 2009 21:27:31 +0300 (MSK) Message-Id: <20090309182731.621869188@gmail.com> User-Agent: quilt/0.47-1 Date: Mon, 09 Mar 2009 21:16:29 +0300 From: Cyrill Gorcunov To: davem@davemloft.net, kaber@trash.net Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org, xemul@openvz.org, adobriyan@gmail.com, Cyrill Gorcunov Subject: [RFC 1/4] net: sysctl_net - use net_eq to compare nets References: <20090309181628.109019157@gmail.com> Content-Disposition: inline; filename=net-sysctl-net-use-net_eq Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Cyrill Gorcunov --- Btw, wouldn't be better to have a special macro/inline to check if net is init_net? Something like is_init_net() net/sysctl_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6.git/net/sysctl_net.c =================================================================== --- linux-2.6.git.orig/net/sysctl_net.c +++ linux-2.6.git/net/sysctl_net.c @@ -61,7 +61,7 @@ static struct ctl_table_root net_sysctl_ static int net_ctl_ro_header_perms(struct ctl_table_root *root, struct nsproxy *namespaces, struct ctl_table *table) { - if (namespaces->net_ns == &init_net) + if (net_eq(namespaces->net_ns, &init_net)) return table->mode; else return table->mode & ~0222;