From patchwork Wed Feb 25 01:42:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lennert Buytenhek X-Patchwork-Id: 23681 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 6C443DDE31 for ; Wed, 25 Feb 2009 12:42:36 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756064AbZBYBmK (ORCPT ); Tue, 24 Feb 2009 20:42:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755809AbZBYBmI (ORCPT ); Tue, 24 Feb 2009 20:42:08 -0500 Received: from xi.wantstofly.org ([80.101.37.227]:53068 "EHLO xi.wantstofly.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755616AbZBYBmH (ORCPT ); Tue, 24 Feb 2009 20:42:07 -0500 Received: by xi.wantstofly.org (Postfix, from userid 500) id 831B77F835; Wed, 25 Feb 2009 02:42:05 +0100 (CET) Date: Wed, 25 Feb 2009 02:42:05 +0100 From: Lennert Buytenhek To: David Miller Cc: nico@cam.org, netdev@vger.kernel.org Subject: [PATCH 4/4] mv643xx_eth: set sane default receive coalescing timeout Message-ID: <20090225014205.GZ17040@xi.wantstofly.org> Mime-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A receive coalescing timeout of 250 usec appears to strike a good balance between allowing enough received frames to be aggregated for LRO to do its job and not allowing the connection to stall due to delaying ACKs to the remote end for too long. Signed-off-by: Lennert Buytenhek --- drivers/net/mv643xx_eth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c index 2ea964c..40db24d 100644 --- a/drivers/net/mv643xx_eth.c +++ b/drivers/net/mv643xx_eth.c @@ -2958,7 +2958,7 @@ static int mv643xx_eth_probe(struct platform_device *pdev) netif_carrier_off(dev); - set_rx_coal(mp, 0); + set_rx_coal(mp, 250); set_tx_coal(mp, 0); err = register_netdev(dev);