From patchwork Tue Feb 10 07:41:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarek Poplawski X-Patchwork-Id: 22863 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id EF119DDEE3 for ; Tue, 10 Feb 2009 18:42:07 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbZBJHmB (ORCPT ); Tue, 10 Feb 2009 02:42:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751480AbZBJHmB (ORCPT ); Tue, 10 Feb 2009 02:42:01 -0500 Received: from fg-out-1718.google.com ([72.14.220.154]:49137 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbZBJHmA (ORCPT ); Tue, 10 Feb 2009 02:42:00 -0500 Received: by fg-out-1718.google.com with SMTP id 16so1234097fgg.17 for ; Mon, 09 Feb 2009 23:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=uprPd3Dwm0sMzMFaJO2ARB44hGLOmGHq8U1Z2Pr0VLo=; b=KH46Yp9uuaSplhyK50bGDGernVrS2UcGvULTHCJro7+bxFbSjITF/m7lx9PC4rcPqd bHuriYHubX5wxFMhD3YeV6jLxNe9SGy77QOevkhT+Txcg+8/NJi7rWC/WXxhJLdhWZlS rxMng0cRIrtj2ZdXV4Zmnt+TrRD/7f56zM+R0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=ChStSuDf5Z/aewNzuagFSzaip2G41gQE9NjU4o/rwN2YID0beqTK7rWzqe6W38KM5v YZXQ1Vw3QFKjS82PdldJ4bpGBMInHGpBiALnlpx9xOH+7S/0GF74xlRAkz1WZFiW5SC+ diAWgheLYSCKGAJ0IDr42XesGTpU01CL/jMuA= Received: by 10.86.71.1 with SMTP id t1mr3264003fga.3.1234251718488; Mon, 09 Feb 2009 23:41:58 -0800 (PST) Received: from ff.dom.local (bv170.internetdsl.tpnet.pl [80.53.205.170]) by mx.google.com with ESMTPS id 3sm607895fge.42.2009.02.09.23.41.57 (version=SSLv3 cipher=RC4-MD5); Mon, 09 Feb 2009 23:41:58 -0800 (PST) Date: Tue, 10 Feb 2009 07:41:54 +0000 From: Jarek Poplawski To: David Miller Cc: Stephen Hemminger , Badalian Vyacheslav , "netdev@vger.kernel.org" Subject: [PATCH v2 net-next] Re: can't add tc multiq Message-ID: <20090210074154.GA4190@ff.dom.local> References: <20090209081553.4a874433@extreme> <20090209214446.GA2542@ami.dom.local> <20090209144052.6636f069@extreme> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090209144052.6636f069@extreme> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 09, 2009 at 02:40:52PM -0800, Stephen Hemminger wrote: ... > Rather than warning which will buried off on some console that user will never > see (and can cause DoS overload). A better errno should be chosen. I think admins are used to reading console messages, but we can try with a better errno too. Thanks, Jarek P. -------------------> take 2 pkt_sched: sch_multiq: Change errno on non-multiqueue devices use. Current "RTNETLINK answers: Invalid argument" warning, while trying to add multiq qdisc to non-multiqueue device, isn't very helpful and some of these devs can be changed btw., so let's use a better errno. With feedback from Stephen Hemminger Reported-by: Badalian Vyacheslav Signed-off-by: Jarek Poplawski --- net/sched/sch_multiq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c index 7e15186..9127312 100644 --- a/net/sched/sch_multiq.c +++ b/net/sched/sch_multiq.c @@ -202,7 +202,7 @@ static int multiq_tune(struct Qdisc *sch, struct nlattr *opt) int i; if (!netif_is_multiqueue(qdisc_dev(sch))) - return -EINVAL; + return -EOPNOTSUPP; if (nla_len(opt) < sizeof(*qopt)) return -EINVAL;