| Message ID | 20090210.000630.194774286.davem@davemloft.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Alexey Dobriyan <adobriyan@gmail.com> Date: Tue, 10 Feb 2009 11:50:24 +0300 > On Tue, Feb 10, 2009 at 12:06:30AM -0800, David Miller wrote: > > -#define HAVE_ALLOC_SKB /* For the drivers to know */ > > -#define HAVE_ALIGNABLE_SKB /* Ditto 8) */ > > BTW, after net_device_ops conversion will be finished, netdev HAVE_* > macros should be deleted as well. I agree. To be honest the whole HAVE_* was a really dumb idea. Althought I suppose at the time it might have made some kind of sense. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 10, 2009 at 12:06:30AM -0800, David Miller wrote: > -#define HAVE_ALLOC_SKB /* For the drivers to know */ > -#define HAVE_ALIGNABLE_SKB /* Ditto 8) */ BTW, after net_device_ops conversion will be finished, netdev HAVE_* macros should be deleted as well. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 5eba400..9247008 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -29,9 +29,6 @@ #include <linux/dmaengine.h> #include <linux/hrtimer.h> -#define HAVE_ALLOC_SKB /* For the drivers to know */ -#define HAVE_ALIGNABLE_SKB /* Ditto 8) */ - /* Don't change this without changing skb_csum_unnecessary! */ #define CHECKSUM_NONE 0 #define CHECKSUM_UNNECESSARY 1
I've commited the following to net-next-2.6 net: Kill skbuff macros from the stone ages. This kills of HAVE_ALLOC_SKB and HAVE_ALIGNABLE_SKB. Nothing in-tree uses them and nothing in-tree has used them since 2.0.x times. Signed-off-by: David S. Miller <davem@davemloft.net> --- include/linux/skbuff.h | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)