From patchwork Thu Jan 29 10:49:10 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ingo Molnar X-Patchwork-Id: 20994 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 458C2DDF48 for ; Thu, 29 Jan 2009 21:49:32 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbZA2Kt0 (ORCPT ); Thu, 29 Jan 2009 05:49:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751716AbZA2Kt0 (ORCPT ); Thu, 29 Jan 2009 05:49:26 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:60564 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbZA2KtY (ORCPT ); Thu, 29 Jan 2009 05:49:24 -0500 Received: from elvis.elte.hu ([157.181.1.14]) by mx2.mail.elte.hu with esmtp (Exim) id 1LSUSO-0006yu-Rb from ; Thu, 29 Jan 2009 11:49:15 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id 1FDA13E21AA; Thu, 29 Jan 2009 11:49:06 +0100 (CET) Date: Thu, 29 Jan 2009 11:49:10 +0100 From: Ingo Molnar To: Arjan van de Ven , "H. Peter Anvin" Cc: Linux Kernel Mailing List , Linus Torvalds , Andrew Morton , NetDev , x86@kernel.org, Dave Airlie Subject: Re: Oops / Warning report for the week of January 28th, 2009: The 200.000th trace. Message-ID: <20090129104910.GA10987@elte.hu> References: <4980A0D8.80209@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4980A0D8.80209@linux.intel.com> User-Agent: Mutt/1.5.18 (2008-05-17) Received-SPF: neutral (mx2: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org * Arjan van de Ven wrote: > Rank 3: mtrr_trim_uncached_memory (warning) > Reported 709 times (14696 total reports) > BIOS bug (often in VMWare) where the MTRR's are set up incorrectly or not at all > This warning was last seen in version 2.6.29-rc2-git1, and first seen in 2.6.24. > More info: http://www.kerneloops.org/searchweek.php?search=mtrr_trim_uncached_memory This bug is not finding any real issues for us anymore and this rate of false positives is a distraction - so i've queued up the patch below in tip/x86/urgent. Ingo ---------------------> From bf3647c44bc76c43c4b2ebb4c37a559e899ac70e Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Thu, 29 Jan 2009 11:45:35 +0100 Subject: [PATCH] x86: tone down mtrr_trim_uncached_memory() warning kerneloops.org is reporting a lot of these warnings that come due to vmware not setting up any MTRRs for emulated CPUs: | Reported 709 times (14696 total reports) | BIOS bug (often in VMWare) where the MTRR's are set up incorrectly | or not at all | | This warning was last seen in version 2.6.29-rc2-git1, and first | seen in 2.6.24. | | More info: | http://www.kerneloops.org/searchweek.php?search=mtrr_trim_uncached_memory Keep a one-liner KERN_INFO about it - so that we have so notice if empty MTRRs are caused by native hardware/BIOS weirdness. Signed-off-by: Ingo Molnar --- arch/x86/kernel/cpu/mtrr/main.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c index d259e5d..236a401 100644 --- a/arch/x86/kernel/cpu/mtrr/main.c +++ b/arch/x86/kernel/cpu/mtrr/main.c @@ -1594,8 +1594,7 @@ int __init mtrr_trim_uncached_memory(unsigned long end_pfn) /* kvm/qemu doesn't have mtrr set right, don't trim them all */ if (!highest_pfn) { - WARN(!kvm_para_available(), KERN_WARNING - "WARNING: strange, CPU MTRRs all blank?\n"); + printk(KERN_INFO "CPU MTRRs all blank - virtualized system.\n"); return 0; }