From patchwork Mon Dec 22 19:17:37 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Eder X-Patchwork-Id: 15286 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 295D3DDE19 for ; Tue, 23 Dec 2008 06:17:47 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755912AbYLVTRp (ORCPT ); Mon, 22 Dec 2008 14:17:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755905AbYLVTRo (ORCPT ); Mon, 22 Dec 2008 14:17:44 -0500 Received: from mail-bw0-f21.google.com ([209.85.218.21]:50184 "EHLO mail-bw0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755891AbYLVTRm (ORCPT ); Mon, 22 Dec 2008 14:17:42 -0500 Received: by mail-bw0-f21.google.com with SMTP id 14so8597306bwz.13 for ; Mon, 22 Dec 2008 11:17:41 -0800 (PST) Received: by 10.103.222.1 with SMTP id z1mr2430537muq.51.1229973460879; Mon, 22 Dec 2008 11:17:40 -0800 (PST) Received: from vmbox.hanneseder.net (chello080109038207.17.14.tuwien.teleweb.at [80.109.38.207]) by mx.google.com with ESMTPS id n10sm10999221mue.52.2008.12.22.11.17.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 22 Dec 2008 11:17:40 -0800 (PST) Received: by vmbox.hanneseder.net (sSMTP sendmail emulation); Mon, 22 Dec 2008 20:17:37 +0100 Subject: [PATCH 18/27] drivers/net/tulip: fix sparse warnings: make do-while a compound statement To: netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 22 Dec 2008 20:17:37 +0100 Message-ID: <20081222191737.11807.16256.stgit@vmbox.hanneseder.net> In-Reply-To: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> User-Agent: StGit/0.14.3.292.gb975 MIME-Version: 1.0 From: Hannes Eder Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix this sparse warnings: drivers/net/tulip/de2104x.c:1695:4: warning: do-while statement is not a compound statement drivers/net/tulip/tulip_core.c:1433:5: warning: do-while statement is not a compound statement Signed-off-by: Hannes Eder --- drivers/net/tulip/de2104x.c | 4 ++-- drivers/net/tulip/tulip_core.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c index 3aa60fa..5166be9 100644 --- a/drivers/net/tulip/de2104x.c +++ b/drivers/net/tulip/de2104x.c @@ -1691,9 +1691,9 @@ static void __devinit de21040_get_mac_address (struct de_private *de) for (i = 0; i < 6; i++) { int value, boguscnt = 100000; - do + do { value = dr32(ROMCmd); - while (value < 0 && --boguscnt > 0); + } while (value < 0 && --boguscnt > 0); de->dev->dev_addr[i] = value; udelay(1); if (boguscnt <= 0) diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c index 1c5ef23..ff84bab 100644 --- a/drivers/net/tulip/tulip_core.c +++ b/drivers/net/tulip/tulip_core.c @@ -1429,9 +1429,9 @@ static int __devinit tulip_init_one (struct pci_dev *pdev, for (i = 0; i < 3; i++) { int value, boguscnt = 100000; iowrite32(0x600 | i, ioaddr + 0x98); - do + do { value = ioread32(ioaddr + CSR9); - while (value < 0 && --boguscnt > 0); + } while (value < 0 && --boguscnt > 0); put_unaligned_le16(value, ((__le16 *)dev->dev_addr) + i); sum += value & 0xffff; }