From patchwork Thu Nov 27 00:03:02 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirsher, Jeffrey T" X-Patchwork-Id: 11073 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B9138DDDF5 for ; Thu, 27 Nov 2008 11:03:20 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbYK0ADQ (ORCPT ); Wed, 26 Nov 2008 19:03:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752609AbYK0ADQ (ORCPT ); Wed, 26 Nov 2008 19:03:16 -0500 Received: from qmta07.emeryville.ca.mail.comcast.net ([76.96.30.64]:43567 "EHLO QMTA07.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbYK0ADP (ORCPT ); Wed, 26 Nov 2008 19:03:15 -0500 Received: from OMTA14.emeryville.ca.mail.comcast.net ([76.96.30.60]) by QMTA07.emeryville.ca.mail.comcast.net with comcast id jx2w1a01G1HpZEsA703Fxt; Thu, 27 Nov 2008 00:03:15 +0000 Received: from gitlost.lost ([63.64.152.142]) by OMTA14.emeryville.ca.mail.comcast.net with comcast id k02u1a00M34bfcX8a02wZt; Thu, 27 Nov 2008 00:03:04 +0000 X-Authority-Analysis: v=1.0 c=1 a=UIQLlmNJOXkA:10 a=gp5lkQqZZo4A:10 a=sEnjJRzHnzVFMYhbEJoA:9 a=0kEGUmEpSXOwwq2aq6AA:7 a=w1nhG9O5oJcIYVgeJaO2XVgN174A:4 a=dGJ0OcVc7YAA:10 a=XF7b4UCPwd8A:10 From: Jeff Kirsher Subject: [NET-NEXT PATCH 5/5] e100: cleanup link up/down messages To: davem@davemloft.net Cc: netdev@vger.kernel.org, Jeff Kirsher Date: Wed, 26 Nov 2008 16:03:02 -0800 Message-ID: <20081127000302.22431.22196.stgit@gitlost.lost> In-Reply-To: <20081127000206.22431.53339.stgit@gitlost.lost> References: <20081127000206.22431.53339.stgit@gitlost.lost> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The system log messages created on a link status change need to follow a specific format to work with tools some customers use. This also makes the messages consistant with other Intel driver link messages. Signed-off-by: Jeff Kirsher --- drivers/net/e100.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/e100.c b/drivers/net/e100.c index 2001a63..dce7ff2 100644 --- a/drivers/net/e100.c +++ b/drivers/net/e100.c @@ -1580,11 +1580,13 @@ static void e100_watchdog(unsigned long data) mii_ethtool_gset(&nic->mii, &cmd); if(mii_link_ok(&nic->mii) && !netif_carrier_ok(nic->netdev)) { - DPRINTK(LINK, INFO, "link up, %sMbps, %s-duplex\n", - cmd.speed == SPEED_100 ? "100" : "10", - cmd.duplex == DUPLEX_FULL ? "full" : "half"); + printk(KERN_INFO "e100: %s NIC Link is Up %s Mbps %s Duplex\n", + nic->netdev->name, + cmd.speed == SPEED_100 ? "100" : "10", + cmd.duplex == DUPLEX_FULL ? "Full" : "Half"); } else if(!mii_link_ok(&nic->mii) && netif_carrier_ok(nic->netdev)) { - DPRINTK(LINK, INFO, "link down\n"); + printk(KERN_INFO "e100: %s NIC Link is Down\n", + nic->netdev->name); } mii_check_link(&nic->mii);