| Message ID | 20081103043033.13607.2028.stgit@jtkirshe-mobile.jf.intel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | Jeff Garzik |
| Headers | show |
Jeff Kirsher wrote: > The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, > so this patch adds a description to the kconfig option. > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > CC: Andrew Gallatin <gallatin@myri.com> > --- > > drivers/net/Kconfig | 18 +++++++++++++++--- > 1 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index f749b40..11f143f 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -2010,9 +2010,13 @@ config IGB_LRO > If in doubt, say N. > > config IGB_DCA > - bool "Enable DCA" > + bool "Direct Cache Access (DCA) Support" > default y > depends on IGB && DCA && !(IGB=y && DCA=m) > + ---help--- > + Say Y here if you want to use Direct Cache Access (DCA) in the > + driver. DCA is a method for warming the CPU cache before data > + is used, with the intent of lessening the impact of cache misses. > > source "drivers/net/ixp2000/Kconfig" > > @@ -2437,9 +2441,13 @@ config IXGBE > will be called ixgbe. > > config IXGBE_DCA > - bool > + bool "Direct Cache Access (DCA) Support" > default y > depends on IXGBE && DCA && !(IXGBE=y && DCA=m) > + ---help--- > + Say Y here if you want to use Direct Cache Access (DCA) in the > + driver. DCA is a method for warming the CPU cache before data > + is used, with the intent of lessening the impact of cache misses. > > config IXGB > tristate "Intel(R) PRO/10GbE support" > @@ -2489,9 +2497,13 @@ config MYRI10GE > will be called myri10ge. > > config MYRI10GE_DCA > - bool > + bool "Direct Cache Access (DCA) Support" > default y > depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m) > + ---help--- > + Say Y here if you want to use Direct Cache Access (DCA) in the > + driver. DCA is a method for warming the CPU cache before data > + is used, with the intent of lessening the impact of cache misses. > > config NETXEN_NIC > tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC" This looks fine to me. Thank you for clarifying. Drew -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff Kirsher wrote: > The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, > so this patch adds a description to the kconfig option. > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > CC: Andrew Gallatin <gallatin@myri.com> > --- > > drivers/net/Kconfig | 18 +++++++++++++++--- > 1 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index f749b40..11f143f 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -2010,9 +2010,13 @@ config IGB_LRO > If in doubt, say N. > > config IGB_DCA > - bool "Enable DCA" > + bool "Direct Cache Access (DCA) Support" > default y > depends on IGB && DCA && !(IGB=y && DCA=m) > + ---help--- > + Say Y here if you want to use Direct Cache Access (DCA) in the > + driver. DCA is a method for warming the CPU cache before data > + is used, with the intent of lessening the impact of cache misses. > > source "drivers/net/ixp2000/Kconfig" > > @@ -2437,9 +2441,13 @@ config IXGBE > will be called ixgbe. > > config IXGBE_DCA > - bool > + bool "Direct Cache Access (DCA) Support" > default y > depends on IXGBE && DCA && !(IXGBE=y && DCA=m) > + ---help--- > + Say Y here if you want to use Direct Cache Access (DCA) in the > + driver. DCA is a method for warming the CPU cache before data > + is used, with the intent of lessening the impact of cache misses. > > config IXGB > tristate "Intel(R) PRO/10GbE support" > @@ -2489,9 +2497,13 @@ config MYRI10GE > will be called myri10ge. > > config MYRI10GE_DCA > - bool > + bool "Direct Cache Access (DCA) Support" > default y > depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m) > + ---help--- > + Say Y here if you want to use Direct Cache Access (DCA) in the > + driver. DCA is a method for warming the CPU cache before data > + is used, with the intent of lessening the impact of cache misses. > applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index f749b40..11f143f 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2010,9 +2010,13 @@ config IGB_LRO If in doubt, say N. config IGB_DCA - bool "Enable DCA" + bool "Direct Cache Access (DCA) Support" default y depends on IGB && DCA && !(IGB=y && DCA=m) + ---help--- + Say Y here if you want to use Direct Cache Access (DCA) in the + driver. DCA is a method for warming the CPU cache before data + is used, with the intent of lessening the impact of cache misses. source "drivers/net/ixp2000/Kconfig" @@ -2437,9 +2441,13 @@ config IXGBE will be called ixgbe. config IXGBE_DCA - bool + bool "Direct Cache Access (DCA) Support" default y depends on IXGBE && DCA && !(IXGBE=y && DCA=m) + ---help--- + Say Y here if you want to use Direct Cache Access (DCA) in the + driver. DCA is a method for warming the CPU cache before data + is used, with the intent of lessening the impact of cache misses. config IXGB tristate "Intel(R) PRO/10GbE support" @@ -2489,9 +2497,13 @@ config MYRI10GE will be called myri10ge. config MYRI10GE_DCA - bool + bool "Direct Cache Access (DCA) Support" default y depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m) + ---help--- + Say Y here if you want to use Direct Cache Access (DCA) in the + driver. DCA is a method for warming the CPU cache before data + is used, with the intent of lessening the impact of cache misses. config NETXEN_NIC tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC"
The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this patch adds a description to the kconfig option. Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> CC: Andrew Gallatin <gallatin@myri.com> --- drivers/net/Kconfig | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html