From patchwork Mon Oct 13 06:06:15 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Grundler X-Patchwork-Id: 4128 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id C388EDDEE8 for ; Mon, 13 Oct 2008 17:06:33 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752831AbYJMGGb (ORCPT ); Mon, 13 Oct 2008 02:06:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752795AbYJMGGa (ORCPT ); Mon, 13 Oct 2008 02:06:30 -0400 Received: from colo.lackof.org ([198.49.126.79]:45209 "EHLO colo.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbYJMGG3 (ORCPT ); Mon, 13 Oct 2008 02:06:29 -0400 Received: from localhost (localhost [127.0.0.1]) by colo.lackof.org (Postfix) with ESMTP id 3183129806C; Mon, 13 Oct 2008 00:06:27 -0600 (MDT) Received: from colo.lackof.org ([127.0.0.1]) by localhost (colo.lackof.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 01831-04; Mon, 13 Oct 2008 00:06:16 -0600 (MDT) Received: by colo.lackof.org (Postfix, from userid 27253) id B948F298029; Mon, 13 Oct 2008 00:06:15 -0600 (MDT) Date: Mon, 13 Oct 2008 00:06:15 -0600 From: Grant Grundler To: linux-driver@qlogic.com Cc: netdev@vger.kernel.org, ron.mercer@qlogic.com, linux-ia64@vger.kernel.org Subject: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Message-ID: <20081013060615.GB29358@colo.lackof.org> MIME-Version: 1.0 Content-Disposition: inline X-Home-Page: http://www.parisc-linux.org/ User-Agent: Mutt/1.5.16 (2007-06-11) X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at lackof.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org QLGE driver only supports 4k, 8k, and 64k pages. Default page size on ia64 is 16k. Compile fails with: drivers/net/qlge/qlge.h:1118: error: 'TX_DESC_PER_OAL' undeclared here (not in a function) Patch below makes the cause of the compile failure obvious. (Better would be to support 16k pages but I don't have the HW or interest.) Signed-off-by: Grant Grundler --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h index c37ea43..cf68503 100644 --- a/drivers/net/qlge/qlge.h +++ b/drivers/net/qlge/qlge.h @@ -60,6 +60,8 @@ #define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2) #elif (PAGE_SHIFT == 16) /* 64k pages */ #define TX_DESC_PER_OAL 0 +#else +#error QLGE Driver only supports 4k, 8k, or 64k CPU page size. #endif #define DB_PAGE_SIZE 4096