Message ID | 200809222150.m8MLogbY031872@imap1.linux-foundation.org |
---|---|
State | Accepted, archived |
Delegated to: | Jeff Garzik |
Headers | show |
From: akpm@linux-foundation.org Date: Mon, 22 Sep 2008 14:50:42 -0700 > The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / > (d)) but is perhaps more readable. > > An extract of the semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) ... > Signed-off-by: Julia Lawall <julia@diku.dk> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> [ Why is Chas being CC:'d on WAN driver layer patches? He's the ATM maintainer :-) ] Applied to net-next-2.6, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -puN drivers/net/wan/sbni.c~drivers-net-wan-use-div_round_up drivers/net/wan/sbni.c --- a/drivers/net/wan/sbni.c~drivers-net-wan-use-div_round_up +++ a/drivers/net/wan/sbni.c @@ -856,7 +856,7 @@ prepare_to_send( struct sk_buff *skb, len = SBNI_MIN_LEN; nl->tx_buf_p = skb; - nl->tx_frameno = (len + nl->maxframe - 1) / nl->maxframe; + nl->tx_frameno = DIV_ROUND_UP(len, nl->maxframe); nl->framelen = len < nl->maxframe ? len : nl->maxframe; outb( inb( dev->base_addr + CSR0 ) | TR_REQ, dev->base_addr + CSR0 );