From patchwork Tue Mar 28 14:00:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 744297 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vssy76ZJfz9s7N for ; Wed, 29 Mar 2017 01:01:35 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="bIRN06UQ"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbdC1OBb (ORCPT ); Tue, 28 Mar 2017 10:01:31 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:35800 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752743AbdC1OBW (ORCPT ); Tue, 28 Mar 2017 10:01:22 -0400 Received: by mail-lf0-f46.google.com with SMTP id j90so38857672lfk.2 for ; Tue, 28 Mar 2017 07:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=l8+6iqBqsLUesGvLick7K+1Wx8ShFkVlIc3nZTx9qCA=; b=bIRN06UQFaYH+MJzc7sCsRqj6N5UxZ/BS84HiRjUReEXoTVonL5KOgYnlvMuumVEtR SYkjovCw97b+4LnHyWeU55PI8qqq8e3n9zT3fYe/YO9HBSjB25lWnWMMga+CpV35h5b9 9kSdpTncdYS+1J1Ag5tTr4RnOSXY6OWeLwN/qBAaiPqro3VqwqfHT2jdl2slOr6Xh3AP Jq6dHGz7l1VEihyQ746p4BwullXANPkTad46QPXxl+aGEaxiz/6Eud3faa9KAbumhyNV R2fvwcG7OqtP+AvW2XIRjELU1Q/uRnUDcr0J4rylW9s5glRCKTkgCrkq1wJcrlBP1dOI HFyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=l8+6iqBqsLUesGvLick7K+1Wx8ShFkVlIc3nZTx9qCA=; b=C5mJYst9QykOl7IJ70frA0fUqm0jlk4F5kYPNsDSY0pWRfQhgPSvTeLMXueyhDwB6u IJlwpU9jug7tHjF6JvcW8TimUcRaeTMFQth7W1/yQjdpqVf7Kd4m2oHh3izSe7cM9qxJ WT2/MfVKQOfY3LKJ8RuhEYMyN04tEfgeUPubbPJRV1/i8uy6OXAHodwfAKPIbZkqpFFs CtoLREsMAeZHPd9bEVo9P4Qb6E7ralJXPtRd2N0AmaIWuj5nCXYoPQV8LB9GQtLFY/8N w4i8zBmzWRRf49Epvxs0b5G1tPuelgWk3j6kelCQWjLUALEYWAhj7nFL399kdlBUcfrH 2SJA== X-Gm-Message-State: AFeK/H1ZYisuqyxuW/hJ3WEtN/8Ct42rV/y/lmO6C+9GjWcC7eH7IHjD1rZCp5ZK1WGjxSOI X-Received: by 10.28.141.143 with SMTP id p137mr14950469wmd.62.1490709661623; Tue, 28 Mar 2017 07:01:01 -0700 (PDT) Received: from andreyknvl0.muc.corp.google.com ([2a00:79e0:15:2:c48d:9a40:3151:2b41]) by smtp.gmail.com with ESMTPSA id w2sm3750557wmd.19.2017.03.28.07.00.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Mar 2017 07:01:00 -0700 (PDT) Received: by andreyknvl0.muc.corp.google.com (Postfix, from userid 206546) id 41A8F182D75; Tue, 28 Mar 2017 16:00:56 +0200 (CEST) From: Andrey Konovalov To: "David S . Miller" , Eric Dumazet , Willem de Bruijn , Craig Gallek Cc: netdev@vger.kernel.org, Dmitry Vyukov , Kostya Serebryany , Andrey Konovalov Subject: [PATCH v4 5/9] kasan: change report header Date: Tue, 28 Mar 2017 16:00:49 +0200 Message-Id: <1cf237df18589bbefc84d850aacb917931028f22.1490383597.git.andreyknvl@google.com> X-Mailer: git-send-email 2.12.2.564.g063fe858b8-goog In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Change report header format from: BUG: KASAN: use-after-free in unwind_get_return_address+0x28a/0x2c0 at addr ffff880069437950 Read of size 8 by task insmod/3925 to: BUG: KASAN: use-after-free in unwind_get_return_address+0x28a/0x2c0 Read of size 8 at addr ffff880069437950 by task insmod/3925 The exact access address is not usually important, so move it to the second line. This also makes the header look visually balanced. Signed-off-by: Andrey Konovalov --- mm/kasan/report.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/kasan/report.c b/mm/kasan/report.c index f77341979dae..156f998199e2 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -130,11 +130,10 @@ static void print_error_description(struct kasan_access_info *info) { const char *bug_type = get_bug_type(info); - pr_err("BUG: KASAN: %s in %pS at addr %p\n", - bug_type, (void *)info->ip, info->access_addr); - pr_err("%s of size %zu by task %s/%d\n", + pr_err("BUG: KASAN: %s in %pS\n", bug_type, (void *)info->ip); + pr_err("%s of size %zu at addr %p by task %s/%d\n", info->is_write ? "Write" : "Read", info->access_size, - current->comm, task_pid_nr(current)); + info->access_addr, current->comm, task_pid_nr(current)); } static inline bool kernel_or_module_addr(const void *addr)