| Message ID | 1607325625-29945-1-git-send-email-tanhuazhong@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net] net: hns3: remove a misused pragma packed | expand |
From: Huazhong Tan <tanhuazhong@huawei.com> Date: Mon, 7 Dec 2020 15:20:25 +0800 > hclge_dbg_reg_info[] is defined as an array of packed structure > accidentally. However, this array contains pointers, which are > no longer aligned naturally, and cannot be relocated on PPC64. > Hence, when compile-testing this driver on PPC64 with > CONFIG_RELOCATABLE=y (e.g. PowerPC allyesconfig), there will be > some warnings. > > Since each field in structure hclge_qos_pri_map_cmd and > hclge_dbg_bitmap_cmd is type u8, the pragma packed is unnecessary > for these two structures as well, so remove the pragma packed in > hclge_debugfs.h to fix this issue, and this increases > hclge_dbg_reg_info[] by 4 bytes per entry. > > Fixes: a582b78dfc33 ("net: hns3: code optimization for debugfs related to "dump reg"") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com> Applied, thank you.
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h index a9066e6..ca2ab6c 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h @@ -35,8 +35,6 @@ #define HCLGE_DBG_DFX_SSU_2_OFFSET 12 -#pragma pack(1) - struct hclge_qos_pri_map_cmd { u8 pri0_tc : 4, pri1_tc : 4; @@ -85,8 +83,6 @@ struct hclge_dbg_reg_type_info { struct hclge_dbg_reg_common_msg reg_msg; }; -#pragma pack() - static const struct hclge_dbg_dfx_message hclge_dbg_bios_common_reg[] = { {false, "Reserved"}, {true, "BP_CPU_STATE"},
hclge_dbg_reg_info[] is defined as an array of packed structure accidentally. However, this array contains pointers, which are no longer aligned naturally, and cannot be relocated on PPC64. Hence, when compile-testing this driver on PPC64 with CONFIG_RELOCATABLE=y (e.g. PowerPC allyesconfig), there will be some warnings. Since each field in structure hclge_qos_pri_map_cmd and hclge_dbg_bitmap_cmd is type u8, the pragma packed is unnecessary for these two structures as well, so remove the pragma packed in hclge_debugfs.h to fix this issue, and this increases hclge_dbg_reg_info[] by 4 bytes per entry. Fixes: a582b78dfc33 ("net: hns3: code optimization for debugfs related to "dump reg"") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h | 4 ---- 1 file changed, 4 deletions(-)