| Message ID | 1596091430-19486-1-git-send-email-liheng40@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [-next] bnxt_en: Remove superfluous memset() | expand |
From: Li Heng <liheng40@huawei.com> Date: Thu, 30 Jul 2020 14:43:50 +0800 > Fixes coccicheck warning: > > ./drivers/net/ethernet/broadcom/bnxt/bnxt.c:3730:19-37: WARNING: > dma_alloc_coherent use in stats -> hw_stats already zeroes out > memory, so memset is not needed > > dma_alloc_coherent use in status already zeroes out memory, > so memset is not needed > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Li Heng <liheng40@huawei.com> Applied.
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 2622d3c..31fb5a2 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -3732,8 +3732,6 @@ static int bnxt_alloc_stats_mem(struct bnxt *bp, struct bnxt_stats_mem *stats, if (!stats->hw_stats) return -ENOMEM; - memset(stats->hw_stats, 0, stats->len); - stats->sw_stats = kzalloc(stats->len, GFP_KERNEL); if (!stats->sw_stats) goto stats_mem_err;
Fixes coccicheck warning: ./drivers/net/ethernet/broadcom/bnxt/bnxt.c:3730:19-37: WARNING: dma_alloc_coherent use in stats -> hw_stats already zeroes out memory, so memset is not needed dma_alloc_coherent use in status already zeroes out memory, so memset is not needed Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Li Heng <liheng40@huawei.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 -- 1 file changed, 2 deletions(-)