| Message ID | 159569777048.30163.2041497275480123382.stgit@zurg |
|---|---|
| State | Rejected |
| Delegated to: | David Miller |
| Headers | show |
| Series | net/ipv4: add comment about connect() to INADDR_ANY | expand |
From: Konstantin Khlebnikov <koct9i@gmail.com> Date: Sat, 25 Jul 2020 20:22:50 +0300 > Copy comment from net/ipv6/tcp_ipv6.c to help future readers. > > Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com> This function is used by many lookups, not just connect() so the comment is entirely inapropriate here. I'm not applying this, sorry.
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index a01efa062f6b..303fe706cbd2 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2591,6 +2591,7 @@ struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct flowi4 *fl4, } } + /* connect() to INADDR_ANY means loopback (BSD'ism). */ if (!fl4->daddr) { fl4->daddr = fl4->saddr; if (!fl4->daddr)
Copy comment from net/ipv6/tcp_ipv6.c to help future readers. Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com> --- net/ipv4/route.c | 1 + 1 file changed, 1 insertion(+)