diff mbox series

[bpf-next,V2,1/2] selftests/bpf: test_progs use another shell exit on non-actions

Message ID 159405481147.1091613.18095872509921723823.stgit@firesoul
State Changes Requested
Delegated to: BPF Maintainers
Headers show
Series BPF selftests test runner 'test_progs' use proper shell exit codes | expand

Commit Message

Jesper Dangaard Brouer July 6, 2020, 5 p.m. UTC
This is a follow up adjustment to commit 6c92bd5cd465 ("selftests/bpf:
Test_progs indicate to shell on non-actions"), that returns shell exit
indication EXIT_FAILURE (value 1) when user selects a non-existing test.

The problem with using EXIT_FAILURE is that a shell script cannot tell
the difference between a non-existing test and the test failing.

This patch uses value 2 as shell exit indication.
(Aside note unrecognized option parameters use value 64).

Fixes: 6c92bd5cd465 ("selftests/bpf: Test_progs indicate to shell on non-actions")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
 tools/testing/selftests/bpf/test_progs.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
index 104e833d0087..e8f7cd5dbae4 100644
--- a/tools/testing/selftests/bpf/test_progs.c
+++ b/tools/testing/selftests/bpf/test_progs.c
@@ -12,6 +12,8 @@ 
 #include <string.h>
 #include <execinfo.h> /* backtrace */
+#define EXIT_NO_TEST 2
 /* defined in test_progs.h */
 struct test_env env = {};
@@ -740,7 +742,7 @@  int main(int argc, char **argv)
 	if (env.succ_cnt + env.fail_cnt + env.skip_cnt == 0)
-		return EXIT_FAILURE;
+		return EXIT_NO_TEST;
 	return env.fail_cnt ? EXIT_FAILURE : EXIT_SUCCESS;