| Message ID | 1592640947-10421-3-git-send-email-vasundhara-v.volam@broadcom.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | devlink: Add board_serial_number field to info_get cb. | expand |
Sat, Jun 20, 2020 at 10:15:47AM CEST, vasundhara-v.volam@broadcom.com wrote: >Add board_serial_number field info to info_get cb via devlink, >if driver can fetch the information from the device. > >Cc: Jiri Pirko <jiri@mellanox.com> >Cc: Jakub Kicinski <kuba@kernel.org> >Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com> >Reviewed-by: Michael Chan <michael.chan@broadcom.com> >--- > drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c >index a812beb..16eca3b 100644 >--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c >+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c >@@ -411,6 +411,13 @@ static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req, > return rc; > } > >+ if (strlen(bp->board_serialno)) { >+ rc = devlink_info_board_serial_number_put(req, No need for linebreak here. >+ bp->board_serialno); >+ if (rc) >+ return rc; >+ } >+ > sprintf(buf, "%X", bp->chip_num); > rc = devlink_info_version_fixed_put(req, > DEVLINK_INFO_VERSION_GENERIC_ASIC_ID, buf); >-- >1.8.3.1 >
On Sat, Jun 20, 2020 at 6:37 PM Jiri Pirko <jiri@resnulli.us> wrote: > > Sat, Jun 20, 2020 at 10:15:47AM CEST, vasundhara-v.volam@broadcom.com wrote: > >Add board_serial_number field info to info_get cb via devlink, > >if driver can fetch the information from the device. > > > >Cc: Jiri Pirko <jiri@mellanox.com> > >Cc: Jakub Kicinski <kuba@kernel.org> > >Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com> > >Reviewed-by: Michael Chan <michael.chan@broadcom.com> > >--- > > drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > >index a812beb..16eca3b 100644 > >--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > >+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > >@@ -411,6 +411,13 @@ static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req, > > return rc; > > } > > > >+ if (strlen(bp->board_serialno)) { > >+ rc = devlink_info_board_serial_number_put(req, > > No need for linebreak here. Ah yes, now the column limit is 100. I will fix and send a v2. Thanks. > > >+ bp->board_serialno); > >+ if (rc) > >+ return rc; > >+ } > >+ > > sprintf(buf, "%X", bp->chip_num); > > rc = devlink_info_version_fixed_put(req, > > DEVLINK_INFO_VERSION_GENERIC_ASIC_ID, buf); > >-- > >1.8.3.1 > >
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index a812beb..16eca3b 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c @@ -411,6 +411,13 @@ static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req, return rc; } + if (strlen(bp->board_serialno)) { + rc = devlink_info_board_serial_number_put(req, + bp->board_serialno); + if (rc) + return rc; + } + sprintf(buf, "%X", bp->chip_num); rc = devlink_info_version_fixed_put(req, DEVLINK_INFO_VERSION_GENERIC_ASIC_ID, buf);