From patchwork Thu Jun 11 05:11:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Li RongQing X-Patchwork-Id: 1307312 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: incoming-bpf@patchwork.ozlabs.org Delivered-To: patchwork-incoming-bpf@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=bpf-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=baidu.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49jBm02SY5z9sSF for ; Thu, 11 Jun 2020 15:11:28 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725873AbgFKFLY (ORCPT ); Thu, 11 Jun 2020 01:11:24 -0400 Received: from mx140-tc.baidu.com ([61.135.168.140]:46171 "EHLO tc-sys-mailedm01.tc.baidu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725300AbgFKFLX (ORCPT ); Thu, 11 Jun 2020 01:11:23 -0400 Received: from localhost (cp01-cos-dev01.cp01.baidu.com [10.92.119.46]) by tc-sys-mailedm01.tc.baidu.com (Postfix) with ESMTP id 971A4204006E; Thu, 11 Jun 2020 13:11:06 +0800 (CST) From: Li RongQing To: netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH] xdp: fix xsk_generic_xmit errno Date: Thu, 11 Jun 2020 13:11:06 +0800 Message-Id: <1591852266-24017-1-git-send-email-lirongqing@baidu.com> X-Mailer: git-send-email 1.7.1 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org propagate sock_alloc_send_skb error code, not set it to EAGAIN unconditionally, when fail to allocate skb, which maybe causes that user space unnecessary loops Fixes: 35fcde7f8deb "(xsk: support for Tx)" Signed-off-by: Li RongQing Acked-by: Björn Töpel --- net/xdp/xsk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c index b6c0f08bd80d..1ba3ea262c15 100644 --- a/net/xdp/xsk.c +++ b/net/xdp/xsk.c @@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk) len = desc.len; skb = sock_alloc_send_skb(sk, len, 1, &err); if (unlikely(!skb)) { - err = -EAGAIN; goto out; }