| Message ID | 1584101065-3482-3-git-send-email-madalin.bucur@oss.nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | QorIQ DPAA ARM RDBs need internal delay on RGMII | expand |
On Fri, Mar 13, 2020 at 02:04:24PM +0200, Madalin Bucur wrote: > The correct setting for the RGMII ports on LS1043ARDB is to > enable delay on both Rx and Tx so the interface mode used must > be PHY_INTERFACE_MODE_RGMII_ID. > > Since commit 1b3047b5208a80 ("net: phy: realtek: add support for > configuring the RX delay on RTL8211F") the Realtek 8211F PHY driver > has control over the RGMII RX delay and it is disabling it for > RGMII_TXID. The LS1043ARDB uses two such PHYs in RGMII_ID mode but > in the device tree the mode was described as "rgmii_txid". > This issue was not apparent at the time as the PHY driver took the > same action for RGMII_TXID and RGMII_ID back then but it became > visible (RX no longer working) after the above patch. > > Changing the phy-connection-type to "rgmii-id" to address the issue. > > Fixes: bf02f2ffe59c ("arm64: dts: add LS1043A DPAA FMan support") > Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts index 4223a2352d45..dde50c88f5e3 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts @@ -119,12 +119,12 @@ ethernet@e4000 { phy-handle = <&rgmii_phy1>; - phy-connection-type = "rgmii-txid"; + phy-connection-type = "rgmii-id"; }; ethernet@e6000 { phy-handle = <&rgmii_phy2>; - phy-connection-type = "rgmii-txid"; + phy-connection-type = "rgmii-id"; }; ethernet@e8000 {
The correct setting for the RGMII ports on LS1043ARDB is to enable delay on both Rx and Tx so the interface mode used must be PHY_INTERFACE_MODE_RGMII_ID. Since commit 1b3047b5208a80 ("net: phy: realtek: add support for configuring the RX delay on RTL8211F") the Realtek 8211F PHY driver has control over the RGMII RX delay and it is disabling it for RGMII_TXID. The LS1043ARDB uses two such PHYs in RGMII_ID mode but in the device tree the mode was described as "rgmii_txid". This issue was not apparent at the time as the PHY driver took the same action for RGMII_TXID and RGMII_ID back then but it became visible (RX no longer working) after the above patch. Changing the phy-connection-type to "rgmii-id" to address the issue. Fixes: bf02f2ffe59c ("arm64: dts: add LS1043A DPAA FMan support") Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com> --- arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)