| Message ID | 1580029390-32760-15-git-send-email-michael.chan@broadcom.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | bnxt_en: Updates for net-next. | expand |
On Sun, 26 Jan 2020 04:03:08 -0500, Michael Chan wrote: > --- a/Documentation/networking/devlink/devlink-info.rst > +++ b/Documentation/networking/devlink/devlink-info.rst > @@ -59,6 +59,11 @@ board.manufacture > > An identifier of the company or the facility which produced the part. > > +board.nvm_cfg > +------------- > + > +Non-volatile memory version of the board. Could you describe a little more detail? Sounds a little similar to fw.psid which Mellanox has added, perhaps it serves the same purpose and we could reuse that one?
On Mon, Jan 27, 2020 at 5:48 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Sun, 26 Jan 2020 04:03:08 -0500, Michael Chan wrote: > > --- a/Documentation/networking/devlink/devlink-info.rst > > +++ b/Documentation/networking/devlink/devlink-info.rst > > @@ -59,6 +59,11 @@ board.manufacture > > > > An identifier of the company or the facility which produced the part. > > > > +board.nvm_cfg > > +------------- > > + > > +Non-volatile memory version of the board. > > Could you describe a little more detail? Sounds a little similar to > fw.psid which Mellanox has added, perhaps it serves the same purpose > and we could reuse that one? It is almost similar. We can reuse and update documentation in bnxt.rst mentioning that parameter set is present in NVM . Thanks.
On Mon, 27 Jan 2020 11:12:52 +0530, Vasundhara Volam wrote: > On Mon, Jan 27, 2020 at 5:48 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Sun, 26 Jan 2020 04:03:08 -0500, Michael Chan wrote: > > > --- a/Documentation/networking/devlink/devlink-info.rst > > > +++ b/Documentation/networking/devlink/devlink-info.rst > > > @@ -59,6 +59,11 @@ board.manufacture > > > > > > An identifier of the company or the facility which produced the part. > > > > > > +board.nvm_cfg > > > +------------- > > > + > > > +Non-volatile memory version of the board. > > > > Could you describe a little more detail? Sounds a little similar to > > fw.psid which Mellanox has added, perhaps it serves the same purpose > > and we could reuse that one? > It is almost similar. We can reuse and update documentation in > bnxt.rst mentioning > that parameter set is present in NVM . Thanks!
diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst index 0385f15..ab0690e 100644 --- a/Documentation/networking/devlink/devlink-info.rst +++ b/Documentation/networking/devlink/devlink-info.rst @@ -59,6 +59,11 @@ board.manufacture An identifier of the company or the facility which produced the part. +board.nvm_cfg +------------- + +Non-volatile memory version of the board. + fw -- @@ -92,3 +97,9 @@ fw.psid ------- Unique identifier of the firmware parameter set. + +fw.roce +------- + +RoCE firmware version which is responsible for handling roce +management. diff --git a/include/net/devlink.h b/include/net/devlink.h index 5e46c24..9e168a3 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -469,6 +469,8 @@ enum devlink_param_generic_id { #define DEVLINK_INFO_VERSION_GENERIC_BOARD_REV "board.rev" /* Maker of the board */ #define DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE "board.manufacture" +/* Non-volatile memory version of the board */ +#define DEVLINK_INFO_VERSION_GENERIC_BOARD_NVM_CFG "board.nvm_cfg" /* Part number, identifier of asic design */ #define DEVLINK_INFO_VERSION_GENERIC_ASIC_ID "asic.id" @@ -487,6 +489,8 @@ enum devlink_param_generic_id { #define DEVLINK_INFO_VERSION_GENERIC_FW_NCSI "fw.ncsi" /* FW parameter set id */ #define DEVLINK_INFO_VERSION_GENERIC_FW_PSID "fw.psid" +/* RoCE FW version */ +#define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE "fw.roce" struct devlink_region; struct devlink_info_req;