diff mbox series

net: phy: Fix compile warning about of_mdiobus_child_is_phy

Message ID 1577442659-12134-1-git-send-email-yangtiezhu@loongson.cn
State RFC
Delegated to: David Miller
Headers show
Series net: phy: Fix compile warning about of_mdiobus_child_is_phy | expand

Commit Message

Tiezhu Yang Dec. 27, 2019, 10:30 a.m. UTC
Fix the following compile warning when CONFIG_OF_MDIO is not set:

  CC      drivers/net/phy/mdio_bus.o
In file included from drivers/net/phy/mdio_bus.c:23:0:
./include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
 static bool of_mdiobus_child_is_phy(struct device_node *child)
             ^

Fixes: 0aa4d016c043 ("of: mdio: export of_mdiobus_child_is_phy")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 include/linux/of_mdio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring (Arm) Jan. 8, 2020, 4:43 p.m. UTC | #1
On Fri, Dec 27, 2019 at 06:30:59PM +0800, Tiezhu Yang wrote:
> Fix the following compile warning when CONFIG_OF_MDIO is not set:
> 
>   CC      drivers/net/phy/mdio_bus.o
> In file included from drivers/net/phy/mdio_bus.c:23:0:
> ./include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
>  static bool of_mdiobus_child_is_phy(struct device_node *child)
>              ^
> 
> Fixes: 0aa4d016c043 ("of: mdio: export of_mdiobus_child_is_phy")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  include/linux/of_mdio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

A similar patch was already applied.

Rob
diff mbox series

Patch

diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h
index 79bc82e..491a2b7 100644
--- a/include/linux/of_mdio.h
+++ b/include/linux/of_mdio.h
@@ -55,7 +55,7 @@  static inline int of_mdio_parse_addr(struct device *dev,
 }
 
 #else /* CONFIG_OF_MDIO */
-static bool of_mdiobus_child_is_phy(struct device_node *child)
+static inline bool of_mdiobus_child_is_phy(struct device_node *child)
 {
 	return false;
 }