diff mbox series

[net-next,1/2] net: Documentation about deprecating NETIF_F_IP{V6}_CSUM

Message ID 1577396099-3831-2-git-send-email-tom@herbertland.com
State Rejected
Delegated to: David Miller
Headers show
Series net: Warning for protocol specific transmit checksum | expand

Commit Message

Tom Herbert Dec. 26, 2019, 9:34 p.m. UTC 
Add text in netdev-features.txt documenting that NETIF_F_IP_CSUM and
NETIF_F_IPV6_CSUM are being deprecated in favor of NETIF_F_HW_CSUM.
Suggest that legacy drivers can be fixed by advertising NETIF_F_HW_CSUM
and checking skb->protocol.

Signed-off-by: Tom Herbert <tom@herbertland.com>
---
 Documentation/networking/netdev-features.txt | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/Documentation/networking/netdev-features.txt b/Documentation/networking/netdev-features.txt
index 58dd1c1..8500ada 100644
--- a/Documentation/networking/netdev-features.txt
+++ b/Documentation/networking/netdev-features.txt
@@ -106,7 +106,12 @@  For complete description, see comments near the top of include/linux/skbuff.h.
 
 Note: NETIF_F_HW_CSUM is a superset of NETIF_F_IP_CSUM + NETIF_F_IPV6_CSUM.
 It means that device can fill TCP/UDP-like checksum anywhere in the packets
-whatever headers there might be.
+whatever headers there might be. NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM are
+deprecated in favor of NETIF_F_HW_CSUM. Legacy drivers can be converted
+by advertising NETIF_F_HW_CSUM and checking skb->protocol for ETH_P_IP or
+ETH_P_IPV6, if the device does not support checksum offload for the protocol
+in skb->protocol then it can call skb_checksum_help to perform the checksum
+on the host.
 
  * Transmit TCP segmentation offload