| Message ID | 1574363727-5437-4-git-send-email-ioana.ciornei@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | dpaa2-eth: MAC phylink fixes | expand |
On Thu, Nov 21, 2019 at 09:15:27PM +0200, Ioana Ciornei wrote: > The include/linux/phylink.h states: > * When @state->interface is %PHY_INTERFACE_MODE_NA, phylink expects > * MAC driver to return all supported link modes. > > Make the necessary adjustment to meet the requirements. > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> This is independent of patch 1. Acked-by: Russell King <rmk+kernel@armlinux.org.uk> > --- > drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > index efc587515661..d93d71724e5a 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > @@ -95,6 +95,7 @@ static void dpaa2_mac_validate(struct phylink_config *config, > phylink_set(mask, Asym_Pause); > > switch (state->interface) { > + case PHY_INTERFACE_MODE_NA: > case PHY_INTERFACE_MODE_RGMII: > case PHY_INTERFACE_MODE_RGMII_ID: > case PHY_INTERFACE_MODE_RGMII_RXID: > -- > 1.9.1 > >
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c index efc587515661..d93d71724e5a 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c @@ -95,6 +95,7 @@ static void dpaa2_mac_validate(struct phylink_config *config, phylink_set(mask, Asym_Pause); switch (state->interface) { + case PHY_INTERFACE_MODE_NA: case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII_ID: case PHY_INTERFACE_MODE_RGMII_RXID:
The include/linux/phylink.h states: * When @state->interface is %PHY_INTERFACE_MODE_NA, phylink expects * MAC driver to return all supported link modes. Make the necessary adjustment to meet the requirements. Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 1 + 1 file changed, 1 insertion(+)