| Message ID | 1573131824-21664-1-git-send-email-madalin.bucur@nxp.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: phy: at803x: add missing dependency on CONFIG_REGULATOR | expand |
On 11/7/19 5:03 AM, Madalin Bucur wrote: > Compilation fails on PPC targets as CONFIG_REGULATOR is not set and > drivers/regulator/devres.c is not compiled in while functions exported > there are used by drivers/net/phy/at803x.c. Here's the error log: > > LD .tmp_vmlinux1 > drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_set_voltage_sel': > drivers/net/phy/at803x.c:294: undefined reference to `.rdev_get_drvdata' > drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_get_voltage_sel': > drivers/net/phy/at803x.c:306: undefined reference to `.rdev_get_drvdata' > drivers/net/phy/at803x.o: In function `at8031_register_regulators': > drivers/net/phy/at803x.c:359: undefined reference to `.devm_regulator_register' > drivers/net/phy/at803x.c:365: undefined reference to `.devm_regulator_register' > drivers/net/phy/at803x.o:(.data.rel+0x0): undefined reference to `regulator_list_voltage_table' > linux/Makefile:1074: recipe for target 'vmlinux' failed > make[1]: *** [vmlinux] Error 1 > > Fixes: 2f664823a470 ("net: phy: at803x: add device tree binding") > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Humm, I was actually wondering if we were guaranteed to have stubs provided, that seems to answer my question.
From: Madalin Bucur <madalin.bucur@nxp.com> Date: Thu, 7 Nov 2019 15:03:44 +0200 > Compilation fails on PPC targets as CONFIG_REGULATOR is not set and > drivers/regulator/devres.c is not compiled in while functions exported > there are used by drivers/net/phy/at803x.c. Here's the error log: > > LD .tmp_vmlinux1 > drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_set_voltage_sel': > drivers/net/phy/at803x.c:294: undefined reference to `.rdev_get_drvdata' > drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_get_voltage_sel': > drivers/net/phy/at803x.c:306: undefined reference to `.rdev_get_drvdata' > drivers/net/phy/at803x.o: In function `at8031_register_regulators': > drivers/net/phy/at803x.c:359: undefined reference to `.devm_regulator_register' > drivers/net/phy/at803x.c:365: undefined reference to `.devm_regulator_register' > drivers/net/phy/at803x.o:(.data.rel+0x0): undefined reference to `regulator_list_voltage_table' > linux/Makefile:1074: recipe for target 'vmlinux' failed > make[1]: *** [vmlinux] Error 1 > > Fixes: 2f664823a470 ("net: phy: at803x: add device tree binding") > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> Applied, thanks.
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 8bccadf17e60..fd6a82ce49a4 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -441,6 +441,7 @@ config NXP_TJA11XX_PHY config AT803X_PHY tristate "Qualcomm Atheros AR803X PHYs" + depends on REGULATOR help Currently supports the AR8030, AR8031, AR8033 and AR8035 model
Compilation fails on PPC targets as CONFIG_REGULATOR is not set and drivers/regulator/devres.c is not compiled in while functions exported there are used by drivers/net/phy/at803x.c. Here's the error log: LD .tmp_vmlinux1 drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_set_voltage_sel': drivers/net/phy/at803x.c:294: undefined reference to `.rdev_get_drvdata' drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_get_voltage_sel': drivers/net/phy/at803x.c:306: undefined reference to `.rdev_get_drvdata' drivers/net/phy/at803x.o: In function `at8031_register_regulators': drivers/net/phy/at803x.c:359: undefined reference to `.devm_regulator_register' drivers/net/phy/at803x.c:365: undefined reference to `.devm_regulator_register' drivers/net/phy/at803x.o:(.data.rel+0x0): undefined reference to `regulator_list_voltage_table' linux/Makefile:1074: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 1 Fixes: 2f664823a470 ("net: phy: at803x: add device tree binding") Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/phy/Kconfig | 1 + 1 file changed, 1 insertion(+)